From: Christoph Hellwig <hch@infradead.org>
To: Stephen Hemminger <shemminger@osdl.org>
Cc: Christoph Hellwig <hch@infradead.org>,
Jeff Garzik <jgarzik@pobox.com>,
"Amit S. Kale" <amitkale@netxen.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH] netxen: remove private ioctl
Date: Fri, 15 Dec 2006 16:04:33 +0000 [thread overview]
Message-ID: <20061215160433.GA18572@infradead.org> (raw)
In-Reply-To: <20061215075708.57a1b6b6@localhost.localdomain>
On Fri, Dec 15, 2006 at 07:57:08AM -0800, Stephen Hemminger wrote:
> The netxen driver includes a private ioctl that provides access
> to functionality that is already available in other ways. The PCI
> layer has application access hooks (see setpci), and the statistics
> are available in ethtool/netstats.
ACK. The removed code is full of bugs aswell.
next prev parent reply other threads:[~2006-12-15 16:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-05 20:07 [PATCH] netxen: sparse warning and ioctl bug fixes Stephen Hemminger
2006-12-06 16:10 ` Amit S. Kale
2006-12-06 16:30 ` Stephen Hemminger
2006-12-07 10:00 ` Jeff Garzik
2006-12-07 10:09 ` Christoph Hellwig
2006-12-15 15:57 ` [PATCH] netxen: remove private ioctl Stephen Hemminger
2006-12-15 16:04 ` Christoph Hellwig [this message]
2006-12-27 5:36 ` Amit S. Kale
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061215160433.GA18572@infradead.org \
--to=hch@infradead.org \
--cc=amitkale@netxen.com \
--cc=jgarzik@pobox.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).