From: Stephen Hemminger <shemminger@osdl.org>
To: Francois Romieu <romieu@fr.zoreil.com>
Cc: Jeff Garzik <jgarzik@pobox.com>, netdev@vger.kernel.org
Subject: Re: [PATCH 3/3] chelsio: more receive cleanup
Date: Fri, 15 Dec 2006 17:28:00 -0800 [thread overview]
Message-ID: <20061215172800.52713c89@freekitty> (raw)
In-Reply-To: <20061216002604.GA11284@electric-eye.fr.zoreil.com>
On Sat, 16 Dec 2006 01:26:04 +0100
Francois Romieu <romieu@fr.zoreil.com> wrote:
> Stephen Hemminger <shemminger@osdl.org> :
> > Francois Romieu <romieu@fr.zoreil.com> wrote:
> [...]
> > Why, you can't predict copybreak on off
>
> Plain gut feeling. I'd rather spend extra cycles on small packets (whose
> allocation is already optimized) and keep the normal packets less expensive
> on a 10Gb/s network card.
>
Likely/unlikely is an optimization that doesn't make a big difference and
I would rather the compiler choose unless it is something obvious like
an error path or external interrupt (like PHY).
There was some discussion on LKML, which I mostly forgot, that hinted that
on some architectures using likely/unlikely incorrectly could have a major
hit.
--
Stephen Hemminger <shemminger@osdl.org>
next prev parent reply other threads:[~2006-12-16 1:28 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-15 19:07 [PATCH 0/3] chelsio driver changes Stephen Hemminger
2006-12-15 19:07 ` [PATCH 1/3] chelsio: fix error path Stephen Hemminger
2006-12-15 19:07 ` [PATCH 2/3] chelsio: NAPI speed improvement Stephen Hemminger
2006-12-15 19:07 ` [PATCH 3/3] chelsio: more receive cleanup Stephen Hemminger
2006-12-15 20:10 ` Francois Romieu
2006-12-15 22:55 ` Stephen Hemminger
2006-12-16 0:26 ` Francois Romieu
2006-12-16 1:28 ` Stephen Hemminger [this message]
2006-12-26 21:16 ` [PATCH 0/3] chelsio driver changes Jeff Garzik
2007-01-08 19:24 ` [PATCH 1/3] chelsio: error path fix Stephen Hemminger
[not found] ` <20070108112524.730e89f0@dxpl.pdx.osdl.net>
2007-01-08 19:26 ` [PATCH 3/3] chelsio: more rx speedup Stephen Hemminger
2007-01-09 8:42 ` Ingo Oeser
2007-01-09 18:26 ` Stephen Hemminger
2007-01-10 2:08 ` Divy Le Ray
2007-01-10 8:34 ` Ingo Oeser
2007-01-10 8:30 ` Ingo Oeser
2007-01-19 3:05 ` Jeff Garzik
2007-01-08 19:26 ` [PATCH 2/3] chelsio: NAPI speed improvement Stephen Hemminger
2007-01-19 3:05 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061215172800.52713c89@freekitty \
--to=shemminger@osdl.org \
--cc=jgarzik@pobox.com \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).