From: Adrian Bunk <bunk@stusta.de>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: netdev@vger.kernel.org,
Andi Drebes <webmaster@programmierforen.de>,
kernel-janitors@lists.osdl.org
Subject: Re: [KJ] [PATCH] he: tiny space savings
Date: Sun, 17 Dec 2006 19:28:06 +0100 [thread overview]
Message-ID: <20061217182806.GD10316@stusta.de> (raw)
In-Reply-To: <20061217125622.GA4973@martell.zuzino.mipt.ru>
On Sun, Dec 17, 2006 at 03:56:22PM +0300, Alexey Dobriyan wrote:
> From: Andi Drebes <webmaster@programmierforen.de>
>
> text data bss dec hex filename
> 20015 480 28 20523 502b drivers/atm/he.o
> 19997 480 28 20505 5019 drivers/atm/he.o
>
> Signed-off-by: Andi Drebes <webmaster@programmierforen.de>
> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
> ---
>
> drivers/atm/he.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/drivers/atm/he.c
> +++ b/drivers/atm/he.c
> @@ -101,7 +101,7 @@ #endif /* HE_DEBUG */
>
> /* version definition */
>
> -static char *version = "$Id: he.c,v 1.18 2003/05/06 22:57:15 chas Exp $";
> +static const char version[] = "$Id: he.c,v 1.18 2003/05/06 22:57:15 chas Exp $";
>...
Can't we kill this ancient and outdated version string instead?
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
next prev parent reply other threads:[~2006-12-17 18:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-17 12:56 [PATCH] he: tiny space savings Alexey Dobriyan
2006-12-17 18:28 ` Adrian Bunk [this message]
2006-12-17 20:02 ` [KJ] " Alexey Dobriyan
2006-12-17 20:06 ` Adrian Bunk
2006-12-18 1:11 ` David Miller
2006-12-18 4:50 ` [2.6 patch] drivers/atm/he.c: remove ancient version string Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061217182806.GD10316@stusta.de \
--to=bunk@stusta.de \
--cc=adobriyan@gmail.com \
--cc=kernel-janitors@lists.osdl.org \
--cc=netdev@vger.kernel.org \
--cc=webmaster@programmierforen.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).