* Re: [BUG KERNEL 2.6.20-rc1] ftp: get or put stops during file-transfer [not found] ` <20061217232311.f181302f.komurojun-mbn@nifty.com> @ 2006-12-18 3:01 ` Adrian Bunk 2006-12-18 20:55 ` Komuro 2006-12-30 9:50 ` Komuro 0 siblings, 2 replies; 15+ messages in thread From: Adrian Bunk @ 2006-12-18 3:01 UTC (permalink / raw) To: Komuro, jgarzik; +Cc: Al Viro, linux-kernel, netdev On Sun, Dec 17, 2006 at 11:23:11PM +0900, Komuro wrote: > On Sun, 17 Dec 2006 04:02:22 +0000 > Al Viro <viro@ftp.linux.org.uk> wrote: > > > On Sun, Dec 17, 2006 at 09:27:52PM +0900, Komuro wrote: > > > > > > Hello, > > > > > > On kernel 2.6.20-rc1, ftp (get or put) stops > > > during file-transfer. > > > > > > Client: ftp-0.17-33.fc6 (192.168.1.1) > > > Server: vsftpd-2.0.5-8 (192.168.1.3) > > > > > > This problem does _not_ happen on kernel-2.6.19. > > > is it caused by network-subsystem change on 2.6.20-rc1?? > > > > Do you have NAT between you and server? > > No. I don't have NAT between the client and the server. > Actually, the client and the sever is located in same room. > > client -- 100MbpsHub -- server. What network cards are in the client and the server? Are there any error messages your client gives or in the log files? > Thanks! > > Best Regards > Komuro cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [BUG KERNEL 2.6.20-rc1] ftp: get or put stops during file-transfer 2006-12-18 3:01 ` [BUG KERNEL 2.6.20-rc1] ftp: get or put stops during file-transfer Adrian Bunk @ 2006-12-18 20:55 ` Komuro 2006-12-30 9:50 ` Komuro 1 sibling, 0 replies; 15+ messages in thread From: Komuro @ 2006-12-18 20:55 UTC (permalink / raw) To: Adrian Bunk; +Cc: jgarzik, Al Viro, linux-kernel, netdev > > What network cards are in the client and the server? DL10022-based pcmcia network card(both client and server) The driver name is pcnet_cs. > Are there any error messages your client gives or in the log files? no error messages. I capture the packet of ftp transfer by ethereal. I found the malformed packet when it stops. I will investigate it further. Thanks! Best Regards Komuro ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [BUG KERNEL 2.6.20-rc1] ftp: get or put stops during file-transfer 2006-12-18 3:01 ` [BUG KERNEL 2.6.20-rc1] ftp: get or put stops during file-transfer Adrian Bunk 2006-12-18 20:55 ` Komuro @ 2006-12-30 9:50 ` Komuro 2006-12-30 1:23 ` YOSHIFUJI Hideaki / 吉藤英明 1 sibling, 1 reply; 15+ messages in thread From: Komuro @ 2006-12-30 9:50 UTC (permalink / raw) To: Adrian Bunk; +Cc: jgarzik, Al Viro, linux-kernel, netdev, yoshfuji, davem Hi, I investigated the ftp-file-transfer-stop problem by git-bisect method, and found this problem was introduced by "[TCP]: MD5 Signature Option (RFC2385) support" patch. Mr.YOSHIFUJI san, please fix this problem. >commit cfb6eeb4c860592edd123fdea908d23c6ad1c7dc >Author: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org> >Date: Tue Nov 14 19:07:45 2006 -0800 > > [TCP]: MD5 Signature Option (RFC2385) support. > > Based on implementation by Rick Payne. > > Signed-off-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org> > Signed-off-by: David S. Miller <davem@davemloft.net> Best Regards Komuro > On Sun, Dec 17, 2006 at 11:23:11PM +0900, Komuro wrote: > > On Sun, 17 Dec 2006 04:02:22 +0000 > > Al Viro <viro@ftp.linux.org.uk> wrote: > > > > > On Sun, Dec 17, 2006 at 09:27:52PM +0900, Komuro wrote: > > > > > > > > Hello, > > > > > > > > On kernel 2.6.20-rc1, ftp (get or put) stops > > > > during file-transfer. > > > > > > > > Client: ftp-0.17-33.fc6 (192.168.1.1) > > > > Server: vsftpd-2.0.5-8 (192.168.1.3) > > > > > > > > This problem does _not_ happen on kernel-2.6.19. > > > > is it caused by network-subsystem change on 2.6.20-rc1?? > > > > > > Do you have NAT between you and server? > > > > No. I don't have NAT between the client and the server. > > Actually, the client and the sever is located in same room. > > > > client -- 100MbpsHub -- server. ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [BUG KERNEL 2.6.20-rc1] ftp: get or put stops during file-transfer 2006-12-30 9:50 ` Komuro @ 2006-12-30 1:23 ` YOSHIFUJI Hideaki / 吉藤英明 2006-12-30 11:59 ` Komuro 0 siblings, 1 reply; 15+ messages in thread From: YOSHIFUJI Hideaki / 吉藤英明 @ 2006-12-30 1:23 UTC (permalink / raw) To: komurojun-mbn; +Cc: bunk, jgarzik, viro, linux-kernel, netdev, davem, yoshfuji In article <20061230185043.d31d2104.komurojun-mbn@nifty.com> (at Sat, 30 Dec 2006 18:50:43 +0900), Komuro <komurojun-mbn@nifty.com> says: > I investigated the ftp-file-transfer-stop problem by git-bisect method, > and found this problem was introduced by > "[TCP]: MD5 Signature Option (RFC2385) support" patch. > > Mr.YOSHIFUJI san, please fix this problem. Hmm, have you try disabling CONFIG_TCP_MD5SIG? (Is it already disabled?) Are there any specific size of transfer to reproduce this? Do you see similar issue with other simple application? --yoshfuji ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [BUG KERNEL 2.6.20-rc1] ftp: get or put stops during file-transfer 2006-12-30 1:23 ` YOSHIFUJI Hideaki / 吉藤英明 @ 2006-12-30 11:59 ` Komuro 2006-12-30 14:19 ` YOSHIFUJI Hideaki / 吉藤英明 0 siblings, 1 reply; 15+ messages in thread From: Komuro @ 2006-12-30 11:59 UTC (permalink / raw) To: YOSHIFUJI Hideaki / 吉藤英明 Cc: bunk, jgarzik, viro, linux-kernel, netdev, davem > > > I investigated the ftp-file-transfer-stop problem by git-bisect method, > > and found this problem was introduced by > > "[TCP]: MD5 Signature Option (RFC2385) support" patch. > > > > Mr.YOSHIFUJI san, please fix this problem. > > Hmm, have you try disabling CONFIG_TCP_MD5SIG? > (Is it already disabled?) This problem happens both CONFIG_TCP_MD5SIG is disabled and enabled. > Are there any specific size of transfer to reproduce this? When I do ftp 40Mbytes file for 5-times or more, this problem happens. > Do you see similar issue with other simple application? sorry, I don't reproduce this problem on other application. Thanks, Best Regards Komuro. ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [BUG KERNEL 2.6.20-rc1] ftp: get or put stops during file-transfer 2006-12-30 11:59 ` Komuro @ 2006-12-30 14:19 ` YOSHIFUJI Hideaki / 吉藤英明 2006-12-31 9:42 ` Komuro ` (2 more replies) 0 siblings, 3 replies; 15+ messages in thread From: YOSHIFUJI Hideaki / 吉藤英明 @ 2006-12-30 14:19 UTC (permalink / raw) To: komurojun-mbn; +Cc: bunk, jgarzik, viro, linux-kernel, netdev, davem In article <20061230205931.9e430173.komurojun-mbn@nifty.com> (at Sat, 30 Dec 2006 20:59:31 +0900), Komuro <komurojun-mbn@nifty.com> says: > > Do you see similar issue with other simple application? > > sorry, I don't reproduce this problem on other application. Can you reproduce it with other ftp client and/or server? Anyway... Please provide the output of "netstat -na" command during the transfer, and the output of "lsmod | grep conntrack" (just for sure). More questions: What kind of mode do you use? e.g. PORT/EPRT/LPRT/PASV/EPSV/LPSV When the transfer get stuck, are other communication still working? Are there any workaround? e.g. stop-start vsftpd cycle, ifdown-ifup cycle, rmmod/insmod cycle etc. Regards, --yoshfuji ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [BUG KERNEL 2.6.20-rc1] ftp: get or put stops during file-transfer 2006-12-30 14:19 ` YOSHIFUJI Hideaki / 吉藤英明 @ 2006-12-31 9:42 ` Komuro 2007-01-01 17:18 ` Komuro 2007-01-04 20:45 ` Komuro 2 siblings, 0 replies; 15+ messages in thread From: Komuro @ 2006-12-31 9:42 UTC (permalink / raw) To: YOSHIFUJI Hideaki / 吉藤英明 Cc: bunk, jgarzik, viro, linux-kernel, netdev, davem > Can you reproduce it with other ftp client and/or server? O.K. I wiil try to test other ftp client and server. > Please provide the output of "netstat -na" command during the > transfer, and the output of "lsmod | grep conntrack" (just for > sure). Please see the output of "netstat -na" when stuck. (below) CONFIG_NETFILER is diabled in my test configuration ,conntrack modules is not loaded. (CONFIG_IP_DCCP, CONFIG_IP_SCTP, CONFIG_TIPC, CONFIG_IPV6 is also disabled) > What kind of mode do you use? e.g. PORT/EPRT/LPRT/PASV/EPSV/LPSV PASV mode. > When the transfer get stuck, are other communication still working? Other communication works properly. Actually, I can start other ftp session on other console of the same PC. > Are there any workaround? > e.g. stop-start vsftpd cycle, ifdown-ifup cycle, rmmod/insmod cycle etc. I only need to do the killall command. >> output of netstat -na Active Internet connections (servers and established) Proto Recv-Q Send-Q Local Address Foreign Address State tcp 0 0 0.0.0.0:873 0.0.0.0:* LISTEN tcp 0 0 0.0.0.0:111 0.0.0.0:* LISTEN tcp 0 0 192.168.0.6:35737 192.168.0.2:26827 TIME_WAIT tcp 0 0 192.168.0.6:51036 192.168.0.2:21 ESTABLISHED udp 0 0 0.0.0.0:68 0.0.0.0:* udp 0 0 0.0.0.0:867 0.0.0.0:* udp 0 0 0.0.0.0:870 0.0.0.0:* udp 0 0 0.0.0.0:111 0.0.0.0:* Active UNIX domain sockets (servers and established) Proto RefCnt Flags Type State I-Node Path unix 2 [ ACC ] STREAM LISTENING 5056 /tmp/.font-unix/fs7100 unix 2 [ ] DGRAM 1234 @/org/kernel/udev/udevd unix 5 [ ] DGRAM 4748 /dev/log unix 2 [ ACC ] STREAM LISTENING 4917 /var/run/dbus/system_bus_socket unix 2 [ ACC ] STREAM LISTENING 4989 /var/run/acpid.socket unix 2 [ ] DGRAM 5390 unix 3 [ ] STREAM CONNECTED 4920 unix 3 [ ] STREAM CONNECTED 4919 unix 2 [ ] DGRAM 4866 unix 2 [ ] DGRAM 4756 Thanks, Best Regards Komuro ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [BUG KERNEL 2.6.20-rc1] ftp: get or put stops during file-transfer 2006-12-30 14:19 ` YOSHIFUJI Hideaki / 吉藤英明 2006-12-31 9:42 ` Komuro @ 2007-01-01 17:18 ` Komuro 2007-01-04 20:45 ` Komuro 2 siblings, 0 replies; 15+ messages in thread From: Komuro @ 2007-01-01 17:18 UTC (permalink / raw) To: YOSHIFUJI Hideaki / 吉藤英明 Cc: bunk, jgarzik, viro, linux-kernel, netdev, davem > > Can you reproduce it with other ftp client and/or server? I tried the proftpd-1.3.0a-1.fc6(kernel version is 2.6.19). The ftp stop problem does not happen. Therefore, this problem is reproduced when client's kernel-version is 2.6.20-rc1 or later and server is vsftpd. Server's kernel-version is not related with this problem. The ftp-stop-problem happens on client's PC. Please advise. Best Regards Komuro ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [BUG KERNEL 2.6.20-rc1] ftp: get or put stops during file-transfer 2006-12-30 14:19 ` YOSHIFUJI Hideaki / 吉藤英明 2006-12-31 9:42 ` Komuro 2007-01-01 17:18 ` Komuro @ 2007-01-04 20:45 ` Komuro 2007-01-04 12:23 ` Craig Schlenter 2 siblings, 1 reply; 15+ messages in thread From: Komuro @ 2007-01-04 20:45 UTC (permalink / raw) To: YOSHIFUJI Hideaki / 吉藤英明 Cc: bunk, jgarzik, viro, linux-kernel, netdev, davem Hi, I made a patch below. With this patch, the ftp-transfer-stop problem does not happen. Therefore, I think this is not a problem of vsftpd. Mr.YOSHIFUJI san, why did you set TCPOLEN_TSTAMP_ALIGNED to iov_len? --- linux-2.6.20-rc3/net/ipv4/tcp_ipv4.c.orig 2007-01-03 11:50:04.000000000 +0900 +++ linux-2.6.20-rc3/net/ipv4/tcp_ipv4.c 2007-01-03 15:30:44.000000000 +0900 @@ -648,7 +648,7 @@ static void tcp_v4_send_ack(struct tcp_t TCPOLEN_TIMESTAMP); rep.opt[1] = htonl(tcp_time_stamp); rep.opt[2] = htonl(ts); - arg.iov[0].iov_len = TCPOLEN_TSTAMP_ALIGNED; + arg.iov[0].iov_len = sizeof(rep); } /* Swap the send and the receive. */ Best Regards Komuro ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [BUG KERNEL 2.6.20-rc1] ftp: get or put stops during file-transfer 2007-01-04 20:45 ` Komuro @ 2007-01-04 12:23 ` Craig Schlenter 2007-01-09 1:24 ` YOSHIFUJI Hideaki / 吉藤英明 2007-01-09 22:01 ` Komuro 0 siblings, 2 replies; 15+ messages in thread From: Craig Schlenter @ 2007-01-04 12:23 UTC (permalink / raw) To: Komuro Cc: YOSHIFUJI Hideaki / 吉藤英明, bunk, jgarzik, viro, linux-kernel, netdev, davem On Fri, Jan 05, 2007 at 05:45:46AM +0900, Komuro wrote: > Hi, > > I made a patch below. > With this patch, the ftp-transfer-stop problem does not happen. > Therefore, I think this is not a problem of vsftpd. > > Mr.YOSHIFUJI san, why did you set TCPOLEN_TSTAMP_ALIGNED > to iov_len? > > > > --- linux-2.6.20-rc3/net/ipv4/tcp_ipv4.c.orig 2007-01-03 11:50:04.000000000 +0900 > +++ linux-2.6.20-rc3/net/ipv4/tcp_ipv4.c 2007-01-03 15:30:44.000000000 +0900 > @@ -648,7 +648,7 @@ static void tcp_v4_send_ack(struct tcp_t > TCPOLEN_TIMESTAMP); > rep.opt[1] = htonl(tcp_time_stamp); > rep.opt[2] = htonl(ts); > - arg.iov[0].iov_len = TCPOLEN_TSTAMP_ALIGNED; > + arg.iov[0].iov_len = sizeof(rep); Perhaps this was supposed to be arg.iov[0].iov_len += TCPOLEN_TSTAMP_ALIGNED; That's what the ipv6 stuff does in places. bye, --Craig ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [BUG KERNEL 2.6.20-rc1] ftp: get or put stops during file-transfer 2007-01-04 12:23 ` Craig Schlenter @ 2007-01-09 1:24 ` YOSHIFUJI Hideaki / 吉藤英明 2007-01-09 5:11 ` [PATCH] " Craig Schlenter 2007-01-09 22:01 ` Komuro 1 sibling, 1 reply; 15+ messages in thread From: YOSHIFUJI Hideaki / 吉藤英明 @ 2007-01-09 1:24 UTC (permalink / raw) To: craig Cc: komurojun-mbn, bunk, jgarzik, viro, linux-kernel, netdev, davem, yoshfuji In article <20070104122330.GA2233@craigdell.detnet.com> (at Thu, 4 Jan 2007 14:23:30 +0200), Craig Schlenter <craig@codefountain.com> says: > On Fri, Jan 05, 2007 at 05:45:46AM +0900, Komuro wrote: > > Hi, > > > > I made a patch below. > > With this patch, the ftp-transfer-stop problem does not happen. > > Therefore, I think this is not a problem of vsftpd. > > > > Mr.YOSHIFUJI san, why did you set TCPOLEN_TSTAMP_ALIGNED > > to iov_len? > > > > > > > > --- linux-2.6.20-rc3/net/ipv4/tcp_ipv4.c.orig 2007-01-03 11:50:04.000000000 +0900 > > +++ linux-2.6.20-rc3/net/ipv4/tcp_ipv4.c 2007-01-03 15:30:44.000000000 +0900 > > @@ -648,7 +648,7 @@ static void tcp_v4_send_ack(struct tcp_t > > TCPOLEN_TIMESTAMP); > > rep.opt[1] = htonl(tcp_time_stamp); > > rep.opt[2] = htonl(ts); > > - arg.iov[0].iov_len = TCPOLEN_TSTAMP_ALIGNED; > > + arg.iov[0].iov_len = sizeof(rep); > > Perhaps this was supposed to be > arg.iov[0].iov_len += TCPOLEN_TSTAMP_ALIGNED; > > That's what the ipv6 stuff does in places. Good catch! I agree. Craig, please provide a patch for us, please. Thank you again. --yoshfuji ^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH] Re: [BUG KERNEL 2.6.20-rc1] ftp: get or put stops during file-transfer 2007-01-09 1:24 ` YOSHIFUJI Hideaki / 吉藤英明 @ 2007-01-09 5:11 ` Craig Schlenter 2007-01-09 5:22 ` YOSHIFUJI Hideaki / 吉藤英明 0 siblings, 1 reply; 15+ messages in thread From: Craig Schlenter @ 2007-01-09 5:11 UTC (permalink / raw) To: YOSHIFUJI Hideaki / 吉藤英明, davem Cc: komurojun-mbn, bunk, jgarzik, viro, linux-kernel, netdev Hi Dave YOSHIFUJI Hideaki / 吉藤英明 has suggested that I send the patch below to fix the ftp stalls present in the current kernels. All credit goes to Komuro <komurojun-mbn@nifty.com> for tracking this down. The patch is untested but it looks *cough* obviously correct. Signed-off-by: Craig Schlenter <craig@codefountain.com> Thank you! --Craig diff --git a/net/ipv4/tcp_ipv4.c b/net/ipv4/tcp_ipv4.c index bf7a224..12de90a 100644 --- a/net/ipv4/tcp_ipv4.c +++ b/net/ipv4/tcp_ipv4.c @@ -648,7 +648,7 @@ static void tcp_v4_send_ack(struct tcp_timewait_sock *twsk, TCPOLEN_TIMESTAMP); rep.opt[1] = htonl(tcp_time_stamp); rep.opt[2] = htonl(ts); - arg.iov[0].iov_len = TCPOLEN_TSTAMP_ALIGNED; + arg.iov[0].iov_len += TCPOLEN_TSTAMP_ALIGNED; } /* Swap the send and the receive. */ ^ permalink raw reply related [flat|nested] 15+ messages in thread
* Re: [PATCH] Re: [BUG KERNEL 2.6.20-rc1] ftp: get or put stops during file-transfer 2007-01-09 5:11 ` [PATCH] " Craig Schlenter @ 2007-01-09 5:22 ` YOSHIFUJI Hideaki / 吉藤英明 2007-01-09 8:11 ` David Miller 0 siblings, 1 reply; 15+ messages in thread From: YOSHIFUJI Hideaki / 吉藤英明 @ 2007-01-09 5:22 UTC (permalink / raw) To: davem Cc: craig, davem, komurojun-mbn, bunk, jgarzik, viro, linux-kernel, netdev [-- Attachment #1: Type: Text/Plain, Size: 438 bytes --] Dave, please apply. Thank you. In article <20070109051139.GA2229@craigdell.detnet.com> (at Tue, 9 Jan 2007 07:11:39 +0200), Craig Schlenter <craig@codefountain.com> says: > All credit goes to Komuro <komurojun-mbn@nifty.com> for tracking > this down. The patch is untested but it looks *cough* obviously > correct. > > Signed-off-by: Craig Schlenter <craig@codefountain.com> Signed-off-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org> [-- Attachment #2: Type: Message/Rfc822, Size: 3419 bytes --] From: Craig Schlenter <craig@codefountain.com> To: "YOSHIFUJI Hideaki / 吉藤英明" <yoshfuji@linux-ipv6.org>, davem@davemloft.net Cc: komurojun-mbn@nifty.com, bunk@stusta.de, jgarzik@pobox.com, viro@ftp.linux.org.uk, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH] Re: [BUG KERNEL 2.6.20-rc1] ftp: get or put stops during file-transfer Date: Tue, 9 Jan 2007 07:11:39 +0200 Message-ID: <20070109051139.GA2229@craigdell.detnet.com> Hi Dave YOSHIFUJI Hideaki / 吉藤英明 has suggested that I send the patch below to fix the ftp stalls present in the current kernels. All credit goes to Komuro <komurojun-mbn@nifty.com> for tracking this down. The patch is untested but it looks *cough* obviously correct. Signed-off-by: Craig Schlenter <craig@codefountain.com> Thank you! --Craig diff --git a/net/ipv4/tcp_ipv4.c b/net/ipv4/tcp_ipv4.c index bf7a224..12de90a 100644 --- a/net/ipv4/tcp_ipv4.c +++ b/net/ipv4/tcp_ipv4.c @@ -648,7 +648,7 @@ static void tcp_v4_send_ack(struct tcp_timewait_sock *twsk, TCPOLEN_TIMESTAMP); rep.opt[1] = htonl(tcp_time_stamp); rep.opt[2] = htonl(ts); - arg.iov[0].iov_len = TCPOLEN_TSTAMP_ALIGNED; + arg.iov[0].iov_len += TCPOLEN_TSTAMP_ALIGNED; } /* Swap the send and the receive. */ ^ permalink raw reply related [flat|nested] 15+ messages in thread
* Re: [PATCH] Re: [BUG KERNEL 2.6.20-rc1] ftp: get or put stops during file-transfer 2007-01-09 5:22 ` YOSHIFUJI Hideaki / 吉藤英明 @ 2007-01-09 8:11 ` David Miller 0 siblings, 0 replies; 15+ messages in thread From: David Miller @ 2007-01-09 8:11 UTC (permalink / raw) To: yoshfuji; +Cc: craig, komurojun-mbn, bunk, jgarzik, viro, linux-kernel, netdev From: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org> Date: Tue, 09 Jan 2007 14:22:44 +0900 (JST) > Dave, please apply. Thank you. > > In article <20070109051139.GA2229@craigdell.detnet.com> (at Tue, 9 Jan 2007 07:11:39 +0200), Craig Schlenter <craig@codefountain.com> says: > > > All credit goes to Komuro <komurojun-mbn@nifty.com> for tracking > > this down. The patch is untested but it looks *cough* obviously > > correct. > > > > Signed-off-by: Craig Schlenter <craig@codefountain.com> > Signed-off-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org> Applied, thanks everyone. ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [BUG KERNEL 2.6.20-rc1] ftp: get or put stops during file-transfer 2007-01-04 12:23 ` Craig Schlenter 2007-01-09 1:24 ` YOSHIFUJI Hideaki / 吉藤英明 @ 2007-01-09 22:01 ` Komuro 1 sibling, 0 replies; 15+ messages in thread From: Komuro @ 2007-01-09 22:01 UTC (permalink / raw) To: Craig Schlenter Cc: YOSHIFUJI Hideaki / 吉藤英明, bunk, jgarzik, viro, linux-kernel, netdev, davem On Thu, 4 Jan 2007 14:23:30 +0200 Craig Schlenter <craig@codefountain.com> wrote: > > --- linux-2.6.20-rc3/net/ipv4/tcp_ipv4.c.orig 2007-01-03 11:50:04.000000000 +0900 > > +++ linux-2.6.20-rc3/net/ipv4/tcp_ipv4.c 2007-01-03 15:30:44.000000000 +0900 > > @@ -648,7 +648,7 @@ static void tcp_v4_send_ack(struct tcp_t > > TCPOLEN_TIMESTAMP); > > rep.opt[1] = htonl(tcp_time_stamp); > > rep.opt[2] = htonl(ts); > > - arg.iov[0].iov_len = TCPOLEN_TSTAMP_ALIGNED; > > + arg.iov[0].iov_len = sizeof(rep); > > Perhaps this was supposed to be > arg.iov[0].iov_len += TCPOLEN_TSTAMP_ALIGNED; > > That's what the ipv6 stuff does in places. It works properly. Thanks! Best Regards Komuro ^ permalink raw reply [flat|nested] 15+ messages in thread
end of thread, other threads:[~2007-01-09 13:02 UTC | newest]
Thread overview: 15+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20061217212752.d93816b4.komurojun-mbn@nifty.com>
[not found] ` <20061217040222.GD17561@ftp.linux.org.uk>
[not found] ` <20061217232311.f181302f.komurojun-mbn@nifty.com>
2006-12-18 3:01 ` [BUG KERNEL 2.6.20-rc1] ftp: get or put stops during file-transfer Adrian Bunk
2006-12-18 20:55 ` Komuro
2006-12-30 9:50 ` Komuro
2006-12-30 1:23 ` YOSHIFUJI Hideaki / 吉藤英明
2006-12-30 11:59 ` Komuro
2006-12-30 14:19 ` YOSHIFUJI Hideaki / 吉藤英明
2006-12-31 9:42 ` Komuro
2007-01-01 17:18 ` Komuro
2007-01-04 20:45 ` Komuro
2007-01-04 12:23 ` Craig Schlenter
2007-01-09 1:24 ` YOSHIFUJI Hideaki / 吉藤英明
2007-01-09 5:11 ` [PATCH] " Craig Schlenter
2007-01-09 5:22 ` YOSHIFUJI Hideaki / 吉藤英明
2007-01-09 8:11 ` David Miller
2007-01-09 22:01 ` Komuro
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).