* [PATCH] he: tiny space savings
@ 2006-12-17 12:56 Alexey Dobriyan
2006-12-17 18:28 ` [KJ] " Adrian Bunk
2006-12-18 1:11 ` David Miller
0 siblings, 2 replies; 6+ messages in thread
From: Alexey Dobriyan @ 2006-12-17 12:56 UTC (permalink / raw)
To: netdev; +Cc: Andi Drebes, kernel-janitors
From: Andi Drebes <webmaster@programmierforen.de>
text data bss dec hex filename
20015 480 28 20523 502b drivers/atm/he.o
19997 480 28 20505 5019 drivers/atm/he.o
Signed-off-by: Andi Drebes <webmaster@programmierforen.de>
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
---
drivers/atm/he.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/atm/he.c
+++ b/drivers/atm/he.c
@@ -101,7 +101,7 @@ #endif /* HE_DEBUG */
/* version definition */
-static char *version = "$Id: he.c,v 1.18 2003/05/06 22:57:15 chas Exp $";
+static const char version[] = "$Id: he.c,v 1.18 2003/05/06 22:57:15 chas Exp $";
/* declarations */
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [KJ] [PATCH] he: tiny space savings
2006-12-17 12:56 [PATCH] he: tiny space savings Alexey Dobriyan
@ 2006-12-17 18:28 ` Adrian Bunk
2006-12-17 20:02 ` Alexey Dobriyan
2006-12-18 1:11 ` David Miller
1 sibling, 1 reply; 6+ messages in thread
From: Adrian Bunk @ 2006-12-17 18:28 UTC (permalink / raw)
To: Alexey Dobriyan; +Cc: netdev, Andi Drebes, kernel-janitors
On Sun, Dec 17, 2006 at 03:56:22PM +0300, Alexey Dobriyan wrote:
> From: Andi Drebes <webmaster@programmierforen.de>
>
> text data bss dec hex filename
> 20015 480 28 20523 502b drivers/atm/he.o
> 19997 480 28 20505 5019 drivers/atm/he.o
>
> Signed-off-by: Andi Drebes <webmaster@programmierforen.de>
> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
> ---
>
> drivers/atm/he.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/drivers/atm/he.c
> +++ b/drivers/atm/he.c
> @@ -101,7 +101,7 @@ #endif /* HE_DEBUG */
>
> /* version definition */
>
> -static char *version = "$Id: he.c,v 1.18 2003/05/06 22:57:15 chas Exp $";
> +static const char version[] = "$Id: he.c,v 1.18 2003/05/06 22:57:15 chas Exp $";
>...
Can't we kill this ancient and outdated version string instead?
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [KJ] [PATCH] he: tiny space savings
2006-12-17 18:28 ` [KJ] " Adrian Bunk
@ 2006-12-17 20:02 ` Alexey Dobriyan
2006-12-17 20:06 ` Adrian Bunk
0 siblings, 1 reply; 6+ messages in thread
From: Alexey Dobriyan @ 2006-12-17 20:02 UTC (permalink / raw)
To: Adrian Bunk; +Cc: netdev, Andi Drebes, kernel-janitors
On Sun, Dec 17, 2006 at 07:28:06PM +0100, Adrian Bunk wrote:
> On Sun, Dec 17, 2006 at 03:56:22PM +0300, Alexey Dobriyan wrote:
> > From: Andi Drebes <webmaster@programmierforen.de>
> > text data bss dec hex filename
> > 20015 480 28 20523 502b drivers/atm/he.o
> > 19997 480 28 20505 5019 drivers/atm/he.o
> >
> > Signed-off-by: Andi Drebes <webmaster@programmierforen.de>
> > Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
> > ---
> >
> > drivers/atm/he.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > --- a/drivers/atm/he.c
> > +++ b/drivers/atm/he.c
> > @@ -101,7 +101,7 @@ #endif /* HE_DEBUG */
> >
> > /* version definition */
> >
> > -static char *version = "$Id: he.c,v 1.18 2003/05/06 22:57:15 chas Exp $";
> > +static const char version[] = "$Id: he.c,v 1.18 2003/05/06 22:57:15 chas Exp $";
> >...
>
> Can't we kill this ancient and outdated version string instead?
"version" is involved in he_proc_read(). I think, no.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [KJ] [PATCH] he: tiny space savings
2006-12-17 20:02 ` Alexey Dobriyan
@ 2006-12-17 20:06 ` Adrian Bunk
0 siblings, 0 replies; 6+ messages in thread
From: Adrian Bunk @ 2006-12-17 20:06 UTC (permalink / raw)
To: Alexey Dobriyan; +Cc: netdev, Andi Drebes, kernel-janitors
On Sun, Dec 17, 2006 at 11:02:55PM +0300, Alexey Dobriyan wrote:
> On Sun, Dec 17, 2006 at 07:28:06PM +0100, Adrian Bunk wrote:
> > On Sun, Dec 17, 2006 at 03:56:22PM +0300, Alexey Dobriyan wrote:
> > > From: Andi Drebes <webmaster@programmierforen.de>
> > > text data bss dec hex filename
> > > 20015 480 28 20523 502b drivers/atm/he.o
> > > 19997 480 28 20505 5019 drivers/atm/he.o
> > >
> > > Signed-off-by: Andi Drebes <webmaster@programmierforen.de>
> > > Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
> > > ---
> > >
> > > drivers/atm/he.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > --- a/drivers/atm/he.c
> > > +++ b/drivers/atm/he.c
> > > @@ -101,7 +101,7 @@ #endif /* HE_DEBUG */
> > >
> > > /* version definition */
> > >
> > > -static char *version = "$Id: he.c,v 1.18 2003/05/06 22:57:15 chas Exp $";
> > > +static const char version[] = "$Id: he.c,v 1.18 2003/05/06 22:57:15 chas Exp $";
> > >...
> >
> > Can't we kill this ancient and outdated version string instead?
>
> "version" is involved in he_proc_read(). I think, no.
You don;t have to omit this line, but printing a more than 3 years old
CVS tag is silly (I can't believe anyone is parsing the CVS version).
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] he: tiny space savings
2006-12-17 12:56 [PATCH] he: tiny space savings Alexey Dobriyan
2006-12-17 18:28 ` [KJ] " Adrian Bunk
@ 2006-12-18 1:11 ` David Miller
2006-12-18 4:50 ` [2.6 patch] drivers/atm/he.c: remove ancient version string Adrian Bunk
1 sibling, 1 reply; 6+ messages in thread
From: David Miller @ 2006-12-18 1:11 UTC (permalink / raw)
To: adobriyan; +Cc: netdev, webmaster, kernel-janitors, bunk
From: Alexey Dobriyan <adobriyan@gmail.com>
Date: Sun, 17 Dec 2006 15:56:22 +0300
> From: Andi Drebes <webmaster@programmierforen.de>
>
> text data bss dec hex filename
> 20015 480 28 20523 502b drivers/atm/he.o
> 19997 480 28 20505 5019 drivers/atm/he.o
>
> Signed-off-by: Andi Drebes <webmaster@programmierforen.de>
> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
As Adrian said, this CVS string is totally useless.
That being said, it should be replaced with an
appropriate piece of versioning information, like
the ones we use via MODULE_VERSION() in other drivers.
I'll be happy to apply a patch which gets rid of the
CVS references, and replaces it with something useful.
Thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [2.6 patch] drivers/atm/he.c: remove ancient version string
2006-12-18 1:11 ` David Miller
@ 2006-12-18 4:50 ` Adrian Bunk
0 siblings, 0 replies; 6+ messages in thread
From: Adrian Bunk @ 2006-12-18 4:50 UTC (permalink / raw)
To: David Miller; +Cc: adobriyan, netdev, webmaster, kernel-janitors
On Sun, Dec 17, 2006 at 05:11:59PM -0800, David Miller wrote:
> From: Alexey Dobriyan <adobriyan@gmail.com>
> Date: Sun, 17 Dec 2006 15:56:22 +0300
>
> > From: Andi Drebes <webmaster@programmierforen.de>
> >
> > text data bss dec hex filename
> > 20015 480 28 20523 502b drivers/atm/he.o
> > 19997 480 28 20505 5019 drivers/atm/he.o
> >
> > Signed-off-by: Andi Drebes <webmaster@programmierforen.de>
> > Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
>
> As Adrian said, this CVS string is totally useless.
>
> That being said, it should be replaced with an
> appropriate piece of versioning information, like
> the ones we use via MODULE_VERSION() in other drivers.
Which versioning information?
There does not seem to be any versioning information that is
getting updated.
There are some truly exceptional cases where maintainers are using and
updating version strings, but in all other cases there's simply nothing
that's worth being printed.
> I'll be happy to apply a patch which gets rid of the
> CVS references, and replaces it with something useful.
Patch below.
> Thanks.
cu
Adrian
<-- snip -->
This patch removes the ancient version string.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
drivers/atm/he.c | 10 ++--------
1 file changed, 2 insertions(+), 8 deletions(-)
--- linux-2.6.20-rc1-mm1/drivers/atm/he.c.old 2006-12-18 05:35:19.000000000 +0100
+++ linux-2.6.20-rc1-mm1/drivers/atm/he.c 2006-12-18 05:39:40.000000000 +0100
@@ -1,5 +1,3 @@
-/* $Id: he.c,v 1.18 2003/05/06 22:57:15 chas Exp $ */
-
/*
he.c
@@ -99,10 +97,6 @@
#define HPRINTK(fmt,args...) do { } while (0)
#endif /* HE_DEBUG */
-/* version definition */
-
-static char *version = "$Id: he.c,v 1.18 2003/05/06 22:57:15 chas Exp $";
-
/* declarations */
static int he_open(struct atm_vcc *vcc);
@@ -366,7 +360,7 @@ he_init_one(struct pci_dev *pci_dev, con
struct he_dev *he_dev = NULL;
int err = 0;
- printk(KERN_INFO "he: %s\n", version);
+ printk(KERN_INFO "ATM he driver\n");
if (pci_enable_device(pci_dev))
return -EIO;
@@ -2933,7 +2927,7 @@ he_proc_read(struct atm_dev *dev, loff_t
left = *pos;
if (!left--)
- return sprintf(page, "%s\n", version);
+ return sprintf(page, "ATM he driver\n");
if (!left--)
return sprintf(page, "%s%s\n\n",
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2006-12-18 4:50 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-12-17 12:56 [PATCH] he: tiny space savings Alexey Dobriyan
2006-12-17 18:28 ` [KJ] " Adrian Bunk
2006-12-17 20:02 ` Alexey Dobriyan
2006-12-17 20:06 ` Adrian Bunk
2006-12-18 1:11 ` David Miller
2006-12-18 4:50 ` [2.6 patch] drivers/atm/he.c: remove ancient version string Adrian Bunk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).