From: David Miller <davem@davemloft.net>
To: herbert@gondor.apana.org.au
Cc: shemminger@osdl.org, mingo@elte.hu, akpm@osdl.org,
wenji@fnal.gov, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: Bug 7596 - Potential performance bottleneck for Linxu TCP
Date: Tue, 19 Dec 2006 18:55:25 -0800 (PST) [thread overview]
Message-ID: <20061219.185525.41636407.davem@davemloft.net> (raw)
In-Reply-To: <E1Gwokt-00050T-00@gondolin.me.apana.org.au>
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Wed, 20 Dec 2006 10:52:19 +1100
> Stephen Hemminger <shemminger@osdl.org> wrote:
> > I noticed this bit of discussion in tcp_recvmsg. It implies that a better
> > queuing policy would be good. But it is confusing English (Alexey?) so
> > not sure where to start.
>
> Actually I think the comment says that the current code isn't the
> most elegant but is more efficient.
It's just explaining the hierarchy of queues that need to
be purged, and in what order, for correctness.
Alexey added that code when I mentioned to him, right after
we added the prequeue, that it was possible process the
normal backlog before the prequeue, which is illegal.
In fixing that bug, he added the comment we are discussing.
next prev parent reply other threads:[~2006-12-20 2:55 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <HNEBLGGMEGLPMPPDOPMGKEAJCGAA.wenji@fnal.gov>
2006-11-29 23:27 ` [Changelog] - Potential performance bottleneck for Linxu TCP Wenji Wu
2006-11-29 23:28 ` [patch 1/4] " Wenji Wu
2006-11-29 23:29 ` [patch 2/4] " Wenji Wu
2006-11-29 23:30 ` [patch 3/4] " Wenji Wu
2006-11-29 23:31 ` [patch 4/4] " Wenji Wu
2006-11-30 0:53 ` [patch 1/4] " David Miller
2006-11-30 1:08 ` Andrew Morton
2006-11-30 1:13 ` David Miller
2006-11-30 6:04 ` Mike Galbraith
2006-11-29 23:36 ` [Changelog] " Martin Bligh
2006-11-29 23:42 ` Bug 7596 " Andrew Morton
2006-11-30 6:32 ` Ingo Molnar
2006-12-19 18:37 ` Stephen Hemminger
2006-12-19 23:52 ` Herbert Xu
2006-12-20 2:55 ` David Miller [this message]
2006-12-20 5:11 ` Stephen Hemminger
2006-12-20 5:15 ` David Miller
2006-11-30 1:01 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061219.185525.41636407.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@osdl.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=netdev@vger.kernel.org \
--cc=shemminger@osdl.org \
--cc=wenji@fnal.gov \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).