From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: Network drivers that don't suspend on interface down Date: Tue, 19 Dec 2006 16:26:08 -0800 Message-ID: <20061219162608.6085d8aa@freekitty> References: <20061220042648.GA19814@srcf.ucam.org> <200612192114.49920.david-b@pacbell.net> <20061220053417.GA29877@suse.de> <20061220055209.GA20483@srcf.ucam.org> <1166601025.3365.1345.camel@laptopd505.fenrus.org> <20061220125314.GA24188@srcf.ucam.org> <1166621931.3365.1384.camel@laptopd505.fenrus.org> <20061220143134.GA25462@srcf.ucam.org> <1166629900.3365.1428.camel@laptopd505.fenrus.org> <20061220144906.7863bcd3@dxpl.pdx.osdl.net> <20061221001111.GA4016@electric-eye.fr.zoreil.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Arjan van de Ven , Matthew Garrett , linux-kernel@vger.kernel.org, netdev@vger.kernel.org Return-path: Received: from smtp.osdl.org ([65.172.181.25]:52674 "EHLO smtp.osdl.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161075AbWLUA07 (ORCPT ); Wed, 20 Dec 2006 19:26:59 -0500 To: Francois Romieu In-Reply-To: <20061221001111.GA4016@electric-eye.fr.zoreil.com> Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Thu, 21 Dec 2006 01:11:12 +0100 Francois Romieu wrote: > Stephen Hemminger : > [...] > > IMHO: > > When device is down, it should: > > a) use as few resources as possible: > > - not grab memory for buffers > > - not assign IRQ unless it could get one > > - turn off all power consumption possible > > b) allow setting parameters like speed/duplex/autonegotiation, > > ring buffers, ... with ethtool, and remember the state > > c) not accept data coming in, and drop packets queued > > > Imho speed/duplex/autoneg is not the business of the device: they belong > to the phy and it's up to it to decide if its state allows to set the > requested parameters or not. > > We need to allow ethtool setting to be done before device has been brought up and started autonegotiation. The current MII library doesn't really support it. -- Stephen Hemminger