From: Andrew Morton <akpm@osdl.org>
To: "Adam J. Richter" <adam@yggdrasil.com>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
Paul Moore <paul.moore@hp.com>
Subject: Re: selinux networking: sleeping functin called from invalid context in 2.6.20-rc[12]
Date: Sun, 24 Dec 2006 16:25:11 -0800 [thread overview]
Message-ID: <20061224162511.eaac4a89.akpm@osdl.org> (raw)
In-Reply-To: <20061225052124.A10323@freya>
On Mon, 25 Dec 2006 05:21:24 +0800
"Adam J. Richter" <adam@yggdrasil.com> wrote:
> Under 2.6.20-rc1 and 2.6.20-rc2, I get the following complaint
> for several network programs running on my system:
>
> [ 156.381868] BUG: sleeping function called from invalid context at net/core/sock.c:1523
> [ 156.381876] in_atomic():1, irqs_disabled():0
> [ 156.381881] no locks held by kio_http/9693.
> [ 156.381886] [<c01057a2>] show_trace_log_lvl+0x1a/0x2f
> [ 156.381900] [<c0105dab>] show_trace+0x12/0x14
> [ 156.381908] [<c0105e48>] dump_stack+0x16/0x18
> [ 156.381917] [<c011e30f>] __might_sleep+0xe5/0xeb
> [ 156.381926] [<c025942a>] lock_sock_nested+0x1d/0xc4
> [ 156.381937] [<c01cc570>] selinux_netlbl_inode_permission+0x5a/0x8e
> [ 156.381946] [<c01c2505>] selinux_file_permission+0x96/0x9b
> [ 156.381954] [<c0175a0a>] vfs_write+0x8d/0x167
> [ 156.381962] [<c017605a>] sys_write+0x3f/0x63
> [ 156.381971] [<c01040c0>] syscall_call+0x7/0xb
> [ 156.381980] =======================
>
There's a glaring bug in selinux_netlbl_inode_permission() - taking
lock_sock() inside rcu_read_lock().
I would again draw attention to Documentation/SubmitChecklist. In
particular please always always always enable all kernel debugging options
when developing and testing new kernel code. And everything else in that
file, too.
<guesses that this was tested on ia64>
next parent reply other threads:[~2006-12-25 0:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20061225052124.A10323@freya>
2006-12-25 0:25 ` Andrew Morton [this message]
2007-01-02 7:58 ` selinux networking: sleeping functin called from invalid context in 2.6.20-rc[12] Adam J. Richter
2007-01-02 21:25 ` Paul Moore
2007-01-02 23:37 ` David Miller
2007-01-03 20:46 ` Paul Moore
2007-01-02 20:09 ` [patch] selinux: fix selinux_netlbl_inode_permission() locking Ingo Molnar
2007-01-02 21:14 ` selinux networking: sleeping functin called from invalid context in 2.6.20-rc[12] Paul Moore
2006-12-26 5:30 Paul Moore
-- strict thread matches above, loose matches on Subject: below --
2007-01-04 11:32 Adam J. Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061224162511.eaac4a89.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=adam@yggdrasil.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paul.moore@hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).