From: Amit Kale <amitkale@netxen.com>
To: Jeff Garzik <jeff@garzik.org>
Cc: netdev@vger.kernel.org, brazilnut@us.ibm.com,
netxenproj@linsyssoft.com, rob@netxen.com, sanjeev@netxen.com,
wendyx@us.ibm.com
Subject: Re: [PATCH 7/8] NetXen: Fix for PPC machines.
Date: Wed, 27 Dec 2006 11:16:10 +0530 [thread overview]
Message-ID: <200612271116.11036.amitkale@netxen.com> (raw)
In-Reply-To: <459198E5.7080804@garzik.org>
Thanks a lot for applying.
We'll definitely take care of the patch format problems you've pointed out.
-Amit
On Wednesday 27 December 2006 03:19, Jeff Garzik wrote:
> Amit S. Kale wrote:
> > Signed-off-by: Amit S. Kale <amitkale@netxen.com>
> >
> > netxen_nic.h | 2 +-
> > netxen_nic_init.c | 12 ++++++------
> > netxen_nic_main.c | 4 ++--
>
> applied 7-8.
>
> your patch format is also broken: please read
>
> Documentation/SubmittingPatches, in particular:
> > 12) The canonical patch format
>
> [...]
>
> > The canonical patch message body contains the following:
>
> [...]
>
> > - A marker line containing simply "---".
>
> The diffstat output should come after the marker line, to avoid getting
> pasted into the kernel changelog.
>
> Jeff
next prev parent reply other threads:[~2006-12-27 5:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-18 13:53 [PATCH 7/8] NetXen: Fix for PPC machines Amit S. Kale
2006-12-26 21:49 ` Jeff Garzik
2006-12-27 5:46 ` Amit Kale [this message]
2006-12-27 7:58 ` Christoph Hellwig
2006-12-27 8:06 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200612271116.11036.amitkale@netxen.com \
--to=amitkale@netxen.com \
--cc=brazilnut@us.ibm.com \
--cc=jeff@garzik.org \
--cc=netdev@vger.kernel.org \
--cc=netxenproj@linsyssoft.com \
--cc=rob@netxen.com \
--cc=sanjeev@netxen.com \
--cc=wendyx@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).