From: David Miller <davem@davemloft.net>
To: dean@arctic.org
Cc: hadi@cyberus.ca, netdev@vger.kernel.org
Subject: Re: [patch] ifb double-counts packets
Date: Mon, 01 Jan 2007 19:39:48 -0800 (PST) [thread overview]
Message-ID: <20070101.193948.36924222.davem@davemloft.net> (raw)
In-Reply-To: <Pine.LNX.4.64.0612231355290.29784@twinlark.arctic.org>
From: dean gaudet <dean@arctic.org>
Date: Sat, 23 Dec 2006 13:58:24 -0800 (PST)
> On Sat, 23 Dec 2006, jamal wrote:
>
> > On Sat, 2006-23-12 at 02:35 -0800, dean gaudet wrote:
> > > it seems that ifb counts packets twice... both at xmit time and also in
> > > the tasklet. i'm not sure which one of the two to drop, but here's a
> > > patch for dropping the counting at xmit time.
> >
> > Good catch but not quite right. The correct way to do it is to increment
> > the rx_ counters instead of tx_ right at the top of ifb_xmit().
> >
> > Do you wanna resubmit your patch with these chmages and hopefully tested
> > for your situation?
>
> heh yeah that makes more sense :)
>
> -dean
>
> Signed-off-by: dean gaudet <dean@arctic.org>
Applied, thanks.
prev parent reply other threads:[~2007-01-02 3:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-23 10:35 [patch] ifb double-counts packets dean gaudet
2006-12-23 13:29 ` jamal
2006-12-23 21:58 ` dean gaudet
2006-12-26 18:38 ` jamal
2007-01-02 3:39 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070101.193948.36924222.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dean@arctic.org \
--cc=hadi@cyberus.ca \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).