From: David Miller <davem@davemloft.net>
To: horms@verge.net.au
Cc: netdev@vger.kernel.org, wensong@linux-vs.org, ja@ssi.bg,
ratz@drugphish.ch, jmack@wm7d.net
Subject: Re: [PATCH] [IPVS] replace if .. goto with while
Date: Tue, 02 Jan 2007 00:38:39 -0800 (PST) [thread overview]
Message-ID: <20070102.003839.08324311.davem@davemloft.net> (raw)
In-Reply-To: <20061218031110.GA32036@verge.net.au>
From: Horms <horms@verge.net.au>
Date: Mon, 18 Dec 2006 12:11:11 +0900
> I guess that this code used to be more complex, but replacing
> the goto with a while seems to make things a bit more readable.
> Or in other words, two fairly gratuitous goto are removed.
>
> On a related note, I wonder if there should be a limit to how
> many times it tries.
>
> Signed-Off-By: Simon Horman <horms@verge.net.au>
Yes, there should be, something like a limit of one. :-)
There is no reason to loop on something like this, just
return a failure immediately if creating the kernel thread
fails.
As a side note, if it's easy you might want to convert this
over the the include/linux/kthread.h interfaces. I just did
this for pktgen tonight and it cleaned a lot of stuff up.
next prev parent reply other threads:[~2007-01-02 8:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-18 3:11 [PATCH] [IPVS] replace if .. goto with while Horms
2007-01-02 8:38 ` David Miller [this message]
2007-01-03 13:37 ` Horms
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070102.003839.08324311.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=horms@verge.net.au \
--cc=ja@ssi.bg \
--cc=jmack@wm7d.net \
--cc=netdev@vger.kernel.org \
--cc=ratz@drugphish.ch \
--cc=wensong@linux-vs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).