From: David Miller <davem@davemloft.net>
To: bunk@stusta.de
Cc: samuel@sortiz.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] net/irda/: proper prototypes
Date: Tue, 02 Jan 2007 00:39:53 -0800 (PST) [thread overview]
Message-ID: <20070102.003953.21925510.davem@davemloft.net> (raw)
In-Reply-To: <20061218034626.GY10316@stusta.de>
From: Adrian Bunk <bunk@stusta.de>
Date: Mon, 18 Dec 2006 04:46:26 +0100
> This patch adds proper prototypes for some functions in
> include/net/irda/irda.h
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
...
> +struct net_device;
> +struct packet_type;
> +
> +void irda_proc_register(void);
> +void irda_proc_unregister(void);
> +
> +int irda_sysctl_register(void);
> +void irda_sysctl_unregister(void);
> +
> +int irsock_init(void);
> +void irsock_cleanup(void);
> +
> +int irlap_driver_rcv(struct sk_buff *skb, struct net_device *dev,
> + struct packet_type *ptype, struct net_device *orig_dev);
Remind me why you remove the "extern" from "external" function
declarations all the time?
I don't like it, even if it's "correct", because it is inconsistent
with what we do in the entire rest of the networking code.
next prev parent reply other threads:[~2007-01-02 8:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-18 3:46 [2.6 patch] net/irda/: proper prototypes Adrian Bunk
2006-12-19 22:29 ` Samuel Ortiz
2007-01-02 8:39 ` David Miller [this message]
2007-01-02 12:45 ` Adrian Bunk
2007-01-02 21:02 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2007-02-06 0:30 [patch 02/11] " akpm
2007-02-06 2:01 ` David Miller
2007-02-20 0:07 ` [2.6 patch] " Adrian Bunk
2007-02-20 9:05 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070102.003953.21925510.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=samuel@sortiz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).