From: David Miller <davem@davemloft.net>
To: m.kozlowski@tuxland.pl
Cc: hadi@cyberus.ca, netdev@vger.kernel.org, jeff@garzik.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: ifb error path loop fix
Date: Tue, 02 Jan 2007 15:20:37 -0800 (PST) [thread overview]
Message-ID: <20070102.152037.39159030.davem@davemloft.net> (raw)
In-Reply-To: <200701021149.43365.m.kozlowski@tuxland.pl>
From: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
Date: Tue, 2 Jan 2007 11:49:42 +0100
> Hello David,
>
> > One could argue from a defensive programming perspective that
> > this bug comes from the fact that the ifb_init_one() loop
> > advances state before checking for errors ('i' is advanced before
> > the 'err' check due to the loop construct), and that's why the
> > error recovery code had to be coded specially :-)
>
> Now when I look at it I might be wrong and it is not a bug at all.
> It's just coded in weird way. Anyway isn't there kfree(ifbs) missing
> on error path?
>
> The patch below should clear things a bit (against plain 2.6.20-rc2-mm1).
>
> Signed-off-by: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
Ok, I've removed the original patch from my tree.
I'll let this cleanup sit for a while so others can review
it :-)
prev parent reply other threads:[~2007-01-02 23:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-01 23:55 [PATCH] net: ifb error path loop fix Mariusz Kozlowski
2007-01-02 7:51 ` David Miller
2007-01-02 10:30 ` Jarek Poplawski
2007-01-02 10:49 ` Mariusz Kozlowski
2007-01-02 23:20 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070102.152037.39159030.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=hadi@cyberus.ca \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.kozlowski@tuxland.pl \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox