From: David Miller <davem@davemloft.net>
To: paul.moore@hp.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] INET: fix incorrect "inet_sock->is_icsk" assignment
Date: Thu, 04 Jan 2007 16:57:35 -0800 (PST) [thread overview]
Message-ID: <20070104.165735.102614518.davem@davemloft.net> (raw)
In-Reply-To: <20070104200437.008980288@hp.com>
From: "Paul Moore" <paul.moore@hp.com>
Date: Thu, 04 Jan 2007 15:04:31 -0500
> From: Paul Moore <paul.moore@hp.com>
>
> The inet_create() and inet6_create() functions incorrectly set the
> inet_sock->is_icsk field. Both functions assume that the is_icsk field is
> large enough to hold at least a INET_PROTOSW_ICSK value when it is actually
> only a single bit. This patch corrects the assignment by doing a boolean
> comparison whose result will safely fit into a single bit field.
>
> Signed-off-by: Paul Moore <paul.moore@hp.com>
Applied, thanks a lot Paul.
next prev parent reply other threads:[~2007-01-05 0:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20070104200430.149943972@hp.com>
2007-01-04 20:04 ` [PATCH] INET: fix incorrect "inet_sock->is_icsk" assignment Paul Moore
2007-01-05 0:57 ` David Miller [this message]
2007-01-05 2:32 ` Arnaldo Carvalho de Melo
2007-01-05 5:42 ` David Miller
2007-01-08 13:25 ` Jarek Poplawski
2007-01-08 14:47 ` Paul Moore
2007-01-09 8:43 ` Jarek Poplawski
2007-01-09 14:26 ` Paul Moore
2007-01-09 14:52 ` Arnaldo Carvalho de Melo
2007-01-10 10:01 ` Jarek Poplawski
2007-01-10 13:13 ` Paul Moore
2007-01-10 13:31 ` Jarek Poplawski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070104.165735.102614518.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=paul.moore@hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).