From: Stephen Hemminger <shemminger@osdl.org>
To: Dmitriy Monakhov <dmonakhov@openvz.org>
Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@osdl.org>,
devel@openvz.org, linux-pci@atrey.karlin.mff.cuni.cz,
netdev@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: [PATCH 1/5] fixing errors handling during pci_driver resume stage [net]
Date: Tue, 9 Jan 2007 10:35:30 -0800 [thread overview]
Message-ID: <20070109103530.2f10f823@freekitty> (raw)
In-Reply-To: <87vejgmv51.fsf@sw.ru>
On Tue, 09 Jan 2007 12:01:14 +0300
Dmitriy Monakhov <dmonakhov@openvz.org> wrote:
> network pci drivers have to return correct error code during resume stage in
> case of errors.
> Signed-off-by: Dmitriy Monakhov <dmonakhov@openvz.org>
> -----
Please don't introduce one dev_err() call into a device driver if all the other
error printout's use a different interface.
--
Stephen Hemminger <shemminger@osdl.org>
next prev parent reply other threads:[~2007-01-09 18:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-09 9:01 [PATCH 1/5] fixing errors handling during pci_driver resume stage [net] Dmitriy Monakhov
2007-01-09 18:35 ` Stephen Hemminger [this message]
2007-01-10 11:11 ` Dmitriy Monakhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070109103530.2f10f823@freekitty \
--to=shemminger@osdl.org \
--cc=akpm@osdl.org \
--cc=devel@openvz.org \
--cc=dmonakhov@openvz.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=linux-scsi@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).