From: David Miller <davem@davemloft.net>
To: herbert.xu@redhat.com
Cc: jmorris@redhat.com, netdev@vger.kernel.org
Subject: Re: [IPSEC] flow: Cache negative results
Date: Wed, 10 Jan 2007 01:24:29 -0800 (PST) [thread overview]
Message-ID: <20070110.012429.63126018.davem@davemloft.net> (raw)
In-Reply-To: <20070110072251.GA27030@gondor.apana.org.au>
From: Herbert Xu <herbert.xu@redhat.com>
Date: Wed, 10 Jan 2007 18:22:51 +1100
> This patch also happens to fix a nasty bug where if an expiring
> flow entry that's not at the head happens to trigger a security
> denial, all entries before it are removed from the cache and
> leaked.
Nasty, this is because "fle != NULL" can occur in the
'nocache' path for two reasons. New entry, or the case
that's buggy here, existing entry with out-of-date generation
ID.
Thanks Herbert, I'll look this over some more and apply it some
time tomorrow.
next prev parent reply other threads:[~2007-01-10 9:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-10 7:22 [IPSEC] flow: Cache negative results Herbert Xu
2007-01-10 9:24 ` David Miller [this message]
2007-01-10 14:15 ` James Morris
2007-01-10 15:26 ` Venkat Yekkirala
2007-01-10 17:41 ` Venkat Yekkirala
2007-01-10 20:49 ` Herbert Xu
2007-01-10 21:08 ` Venkat Yekkirala
2007-01-10 23:27 ` Herbert Xu
2007-01-11 6:06 ` David Miller
2007-01-11 11:29 ` Herbert Xu
2007-01-10 16:11 ` Paul Moore
2007-01-10 23:27 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070110.012429.63126018.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=herbert.xu@redhat.com \
--cc=jmorris@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).