From: Christoph Hellwig <hch@infradead.org>
To: Jay Cliburn <jacliburn@bellsouth.net>
Cc: Christoph Hellwig <hch@infradead.org>,
jeff@garzik.org, shemminger@osdl.org, csnook@redhat.com,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH 2/4] atl1: Header files for Attansic L1 driver
Date: Thu, 11 Jan 2007 17:58:33 +0000 [thread overview]
Message-ID: <20070111175833.GA15053@infradead.org> (raw)
In-Reply-To: <20070111165330.GA6191@osprey.hogchain.net>
On Thu, Jan 11, 2007 at 10:53:30AM -0600, Jay Cliburn wrote:
> On Thu, Jan 11, 2007 at 09:27:04AM +0000, Christoph Hellwig wrote:
> > On Wed, Jan 10, 2007 at 06:41:37PM -0600, Jay Cliburn wrote:
> > > +/**
> > > + * atl1.h - atl1 main header
> >
> > Please remove these kind of comments, they get out of date far too soon
> > and don't really help anything. (Also everywhere else in the driver)
>
> Is your concern here with the filename portion of the comment only, or
> with the entire comment including the copyright and other material?
Only the line I quoted. Copyright statements and similar things are
obviously fine :)
next prev parent reply other threads:[~2007-01-11 17:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-11 0:41 [PATCH 2/4] atl1: Header files for Attansic L1 driver Jay Cliburn
2007-01-11 9:27 ` Christoph Hellwig
2007-01-11 16:53 ` Jay Cliburn
2007-01-11 17:44 ` Stephen Hemminger
2007-01-11 17:58 ` Christoph Hellwig [this message]
2007-01-15 19:21 ` Jay Cliburn
2007-01-15 20:33 ` Francois Romieu
2007-01-15 20:45 ` Jay Cliburn
-- strict thread matches above, loose matches on Subject: below --
2007-01-21 21:06 Jay Cliburn
2007-01-22 11:31 ` Francois Romieu
2006-11-19 20:30 Jay Cliburn
2006-11-19 21:36 ` Jan Engelhardt
2006-11-20 6:01 ` Chris Snook
2006-11-20 11:02 ` Jan Engelhardt
2006-11-20 5:54 ` Chris Snook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070111175833.GA15053@infradead.org \
--to=hch@infradead.org \
--cc=csnook@redhat.com \
--cc=jacliburn@bellsouth.net \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).