From: David Miller <davem@davemloft.net>
To: samuel@sortiz.org
Cc: avl@logic.at, netdev@vger.kernel.org, irda-users@lists.sourceforge.net
Subject: Re: [PATCH 1/2] [IrDA] irda-usb TX path optimization
Date: Mon, 15 Jan 2007 19:37:54 -0800 (PST) [thread overview]
Message-ID: <20070115.193754.59662700.davem@davemloft.net> (raw)
In-Reply-To: <20070115091511.GA3532@sortiz.org>
From: Samuel Ortiz <samuel@sortiz.org>
Date: Mon, 15 Jan 2007 11:15:11 +0200
> Since we stop using dev_alloc_skb on the IrDA TX frame, we constantly run
> into the case of the skb headroom being 0, and thus we call skb_cow for
> every IrDA TX frame.
> This patch uses a local buffer and memcpy the skb to it, saving us a
> kmalloc for each of those IrDA TX frames.
>
> Signed-off-by: Samuel Ortiz <samuel@sortiz.org>
Applied, thanks.
Technically this is a bug fix too because once an SKB hits the
transmit function it should essentially be immutable, ie. you
shouldn't be writing to it. tcpdump sniffers could be looking
at the SKB, as one example.
next prev parent reply other threads:[~2007-01-16 3:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-07 0:51 IrDA spams logfiles - since 2.6.19 Andreas Leitgeb
2007-01-10 23:26 ` David Miller
2007-01-11 12:01 ` Samuel Ortiz
2007-01-15 9:15 ` [PATCH 1/2] [IrDA] irda-usb TX path optimization (was Re: IrDA spams logfiles - since 2.6.19) Samuel Ortiz
2007-01-16 3:37 ` David Miller [this message]
2007-01-16 3:48 ` [PATCH 1/2] [IrDA] irda-usb TX path optimization Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070115.193754.59662700.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=avl@logic.at \
--cc=irda-users@lists.sourceforge.net \
--cc=netdev@vger.kernel.org \
--cc=samuel@sortiz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).