From: Jarek Poplawski <jarkao2@o2.pl>
To: Patrick McHardy <kaber@trash.net>
Cc: netdev@vger.kernel.org, shemminger@osdl.org
Subject: Re: [IPROUTE 01/05]: Use tc_calc_xmittime where appropriate
Date: Tue, 16 Jan 2007 13:48:51 +0100 [thread overview]
Message-ID: <20070116124851.GC1003@ff.dom.local> (raw)
In-Reply-To: <45ACC504.4060208@trash.net>
On Tue, Jan 16, 2007 at 01:28:52PM +0100, Patrick McHardy wrote:
> Jarek Poplawski wrote:
> > On Tue, Jan 16, 2007 at 11:19:34AM +0100, Patrick McHardy wrote:
> > ...
> >
> >>Right, this changes it from long (tc_core_usec2tick) to unsigned
> >>int. It doesn't make any difference though, ...
> >
> >
> > ... if we count out reading_time_2tick, of course.
>
> And this is a problem why? In the worst case (NET_SCH_CLK_CPU,
> max rate 1/0.5us) it allows us to represent a transmission time
> of 2^32/1000000/2s (where 2 is tick_in_usec), which is roughly
> 2147s.
>
> If you still have doubts, please use numbers to demonstrate the
> problem.
Sorry, I probably forgot to add "the face".
The only problem is that when reading a patch you have
to guess if this was considered by the author or as in
other place to check all next uses of double variable
to see they actually always store unsigned.
But probably I should correct readability of my posts,
too.
Jarek P.
next prev parent reply other threads:[~2007-01-16 12:46 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-10 10:01 [IPROUTE 00/05]: Time cleanups Patrick McHardy
2007-01-10 10:01 ` [IPROUTE 01/05]: Use tc_calc_xmittime where appropriate Patrick McHardy
2007-01-16 8:56 ` Jarek Poplawski
2007-01-16 10:19 ` Patrick McHardy
2007-01-16 11:02 ` Jarek Poplawski
2007-01-16 12:28 ` Patrick McHardy
2007-01-16 12:48 ` Jarek Poplawski [this message]
2007-01-10 10:01 ` [IPROUTE 02/05]: Introduce tc_calc_xmitsize and use " Patrick McHardy
2007-01-15 12:35 ` Jarek Poplawski
2007-01-15 15:07 ` Patrick McHardy
2007-01-10 10:01 ` [IPROUTE 03/05]: Introduce TIME_UNITS_PER_SEC to represent internal clock resolution Patrick McHardy
2007-01-10 10:01 ` [IPROUTE 04/05]: Replace "usec" by "time" in function names Patrick McHardy
2007-01-15 10:17 ` Jarek Poplawski
2007-01-16 13:42 ` Patrick McHardy
2007-01-10 10:01 ` [IPROUTE 05/05]: Add sprint_ticks() function and use in CBQ Patrick McHardy
-- strict thread matches above, loose matches on Subject: below --
2006-06-23 18:06 [RFC IPROUTE 00/05]: Time cleanups Patrick McHardy
2006-06-23 18:06 ` [IPROUTE 01/05]: Use tc_calc_xmittime where appropriate Patrick McHardy
2006-06-23 18:28 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070116124851.GC1003@ff.dom.local \
--to=jarkao2@o2.pl \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).