From: Jarek Poplawski <jarkao2@o2.pl>
To: Thibaut VARENE <T-Bone@parisc-linux.org>
Cc: Dale Farnsworth <dale@farnsworth.org>,
netdev@vger.kernel.org, mlachwani@mvista.com
Subject: Re: [PATCH] Re: kernel BUG in eth_alloc_tx_desc_index at drivers/net/mv643xx_eth.c:1069!
Date: Mon, 22 Jan 2007 11:02:36 +0100 [thread overview]
Message-ID: <20070122100236.GC2079@ff.dom.local> (raw)
In-Reply-To: <7d01f9f00701210502m2bb96bd8i5071a76b6a8c3ea0@mail.gmail.com>
On Sun, Jan 21, 2007 at 02:02:15PM +0100, Thibaut VARENE wrote:
> On 1/21/07, Thibaut VARENE <T-Bone@parisc-linux.org> wrote:
...
> >Hmm, I think this is guaranteed not to work. In between those lines
> >the lock is released, while data in the mp structure is still being
> >accessed. It seems that this bit of code is indeed not race-safe
> >though, I'm gonna try to figure something.
I only changed the part I was quite sure is wrong.
I didn't know the internals of this place but thought
probably somebody had some reasons to enable irqs here.
I hope the maintainers will decide the range of necessary
changes considering your testing and the patch.
> This was indeed the right spot. The attached raw hack seems to fix the
> bug (I couldn't crash the box so far). I haven't checked that the
> same "situation" happens elsewhere in the code, I leave that as an
> exercise for the maintainers (or until I experience another kind of
> crash :)
>
> The patch is a bit ugly (printk with irq disabled will not show, etc)
> but at least it does work. I'm sure somebody will figure something
Congratulations and regards,
Jarek P.
next prev parent reply other threads:[~2007-01-22 10:00 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-05 19:03 kernel BUG in eth_alloc_tx_desc_index at drivers/net/mv643xx_eth.c:1069! Thibaut VARENE
2007-01-09 9:26 ` Jarek Poplawski
2007-01-09 10:27 ` Thibaut VARENE
2007-01-09 10:52 ` Jarek Poplawski
2007-01-09 10:56 ` Thibaut VARENE
2007-01-09 11:48 ` Jarek Poplawski
2007-01-09 10:57 ` Jarek Poplawski
2007-01-09 13:02 ` Jarek Poplawski
2007-01-09 17:44 ` Thibaut VARENE
2007-01-09 20:05 ` Dale Farnsworth
2007-01-09 21:05 ` Thibaut VARENE
2007-01-10 17:12 ` Thibaut VARENE
2007-01-11 10:42 ` [PATCH] " Jarek Poplawski
2007-01-21 12:18 ` Thibaut VARENE
2007-01-21 13:02 ` Thibaut VARENE
2007-01-22 10:02 ` Jarek Poplawski [this message]
2007-01-22 17:06 ` Dale Farnsworth
2007-01-23 8:17 ` Jarek Poplawski
2007-01-23 11:52 ` Thibaut VARENE
2007-01-23 12:42 ` Thibaut VARENE
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070122100236.GC2079@ff.dom.local \
--to=jarkao2@o2.pl \
--cc=T-Bone@parisc-linux.org \
--cc=dale@farnsworth.org \
--cc=mlachwani@mvista.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).