Netdev List
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: yoshfuji@linux-ipv6.org
Cc: herbert@gondor.apana.org.au, nakagawa.msy@ncos.nec.co.jp,
	netdev@vger.kernel.org, mhuth@mvista.com
Subject: Re: [PATCH 2.6.20-rc5] IPV6: skb is unexpectedly freed.
Date: Tue, 23 Jan 2007 20:40:08 -0800 (PST)	[thread overview]
Message-ID: <20070123.204008.59666972.davem@davemloft.net> (raw)
In-Reply-To: <20070124.133725.07735362.yoshfuji@linux-ipv6.org>

From: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
Date: Wed, 24 Jan 2007 13:37:25 +0900 (JST)

> In article <E1H9ZnX-0001z5-00@gondolin.me.apana.org.au> (at Wed, 24 Jan 2007 15:31:47 +1100), Herbert Xu <herbert@gondor.apana.org.au> says:
> 
> > Masayuki Nakagawa <nakagawa.msy@ncos.nec.co.jp> wrote:
> > > 
> > > I suggest to use kfree_skb() instead of __kfree_skb().
> > 
> > I agree.  In fact please do it for all paths in that function, i.e.,
> > just change __kfree_skb to kfree_skb rather than adding a special case
> > for this path.
> 
> I do think so, too.

So do I, but initially I want to push his basic patch in
so that I can push the same exact thing into -stable to
fix this bug.

So if you make the subsequent change, please make it relative
to the original patch.

Thank you.

  reply	other threads:[~2007-01-24  4:40 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-24  2:15 [PATCH 2.6.20-rc5] IPV6: skb is unexpectedly freed Masayuki Nakagawa
2007-01-24  4:31 ` Herbert Xu
2007-01-24  4:37   ` YOSHIFUJI Hideaki / 吉藤英明
2007-01-24  4:40     ` David Miller [this message]
2007-01-26  3:36       ` Masayuki Nakagawa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070123.204008.59666972.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=mhuth@mvista.com \
    --cc=nakagawa.msy@ncos.nec.co.jp \
    --cc=netdev@vger.kernel.org \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox