From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH 4/4] atl1: Ancillary C files for Attansic L1 driver Date: Tue, 23 Jan 2007 11:25:22 -0800 Message-ID: <20070123112522.65aac61b@freekitty> References: <20070121210737.GE2702@osprey.hogchain.net> <20070121183151.4be61ebf.randy.dunlap@oracle.com> <45B43093.6060500@bellsouth.net> <20070122200004.GA12553@dreamland.darkstar.lan> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Jay Cliburn , Randy Dunlap , jeff@garzik.org, shemminger@osdl.org, csnook@redhat.com, hch@infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, atl1-devel@lists.sourceforge.net, kronos.it@gmail.com Return-path: Received: from smtp.osdl.org ([65.172.181.24]:50491 "EHLO smtp.osdl.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933111AbXAWT27 (ORCPT ); Tue, 23 Jan 2007 14:28:59 -0500 To: Luca Tettamanti In-Reply-To: <20070122200004.GA12553@dreamland.darkstar.lan> Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Mon, 22 Jan 2007 21:00:04 +0100 Luca Tettamanti wrote: > Il Sun, Jan 21, 2007 at 09:33:39PM -0600, Jay Cliburn ha scritto: > > Randy Dunlap wrote: > > >On Sun, 21 Jan 2007 15:07:37 -0600 Jay Cliburn wrote: > > [snip] > > > > >>+ value = ioread16(hw->hw_addr + REG_PCIE_CAP_LIST); > > >>+ return ((value & 0xFF00) == 0x6C00) ? 0 : 1; > > > > > >Are there defines or enums for these? > > >Fewer magic numbers would be nice/helpful/readable. > > [snip] > > >>+ s32 ret; > > >>+ ret = atl1_write_phy_reg(hw, 29, 0x0029); > > > > > >Fewer magic numbers? > > > > Unfortunately, we don't have a spec. This is how the vendor coded it. > > > > [snip] > > >>+ > > >>+int enable_msi; > > >>+module_param(enable_msi, int, 0444); > > >>+MODULE_PARM_DESC(enable_msi, "Enable PCI MSI"); > > > > > >Hm, I thought that we didn't want individual drivers having MSI config > > >options... > > > > Luca? This one was yours IIRC. Care to chime in? > > I remember that discussion, but since there's no sistem-wide MSI > blacklist (or whitelist) I don't think it's safe to enable it > unconditionally. Judging from bug reports on lkml it's not safe to > assume that MSI support is sane on non-Intel chipsets. > > Luca There is MSI blacklisting see drivers/pci/quirks.c code. But the blacklist isn't complete enough yet. IMHO the MSI disabling should be removed from drivers and be done in the PCI core. But it doesn't seem to have gotten widespread support. -- Stephen Hemminger