From: Michael Buesch <mb@bu3sch.de>
To: Pavel Roskin <proski@gnu.org>
Cc: bcm43xx-dev@lists.berlios.de, netdev@vger.kernel.org
Subject: Re: Can someone please try...
Date: Wed, 24 Jan 2007 09:43:24 +0100 [thread overview]
Message-ID: <200701240943.24141.mb@bu3sch.de> (raw)
In-Reply-To: <1169617390.30511.27.camel@dv>
On Wednesday 24 January 2007 06:43, Pavel Roskin wrote:
> On Tue, 2007-01-23 at 10:21 +0100, Michael Buesch wrote:
> > On Tuesday 23 January 2007 07:14, Pavel Roskin wrote:
> > > I have tried the patch, and it doesn't fix the problem. It's a separate
> > > problem. It happens when bcm43xx_interrupt_handler() is called on a
> > > device that has already been removed.
> >
> > That shouldn't happen and doesn't for me.
> >
> > > It looks like
> > > bcm43xx_wireless_core_stop() should be called from
> > > bcm43xx_one_core_detach().
> >
> > No, well... . remove_interface should have been called by the stack, no?
>
> It is not. It's called if I bring the interface down with ifconfig. If
> I remove live interface with "rmmod bcm43xx_d80211",
> bcm43xx_one_core_detach() is called first, followed by kernel panic in
> bcm43xx_interrupt_handler().
>
> And that's what I see in the code. Module removal calls bcm43xx_exit().
> It unregisters the ssb driver first. The ssb layer calls
> bcm43xx_remove(), which calls bcm43xx_one_core_detach() before doing
> anything with the wireless stack or with interrupts.
>
> I tried to put bcm43xx_one_core_detach() to the end of bcm43xx_remove(),
> but the result was the same. Still, I think the solution lies in that
> direction. We should stop the hardware before dismantling any data
> structures.
Ok, I see. I will try to debug this.
--
Greetings Michael.
next prev parent reply other threads:[~2007-01-24 8:44 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-16 17:06 Can someone please try Michael Buesch
2007-01-16 18:29 ` Pavel Roskin
2007-01-16 19:23 ` Michael Buesch
2007-01-16 21:50 ` Pavel Roskin
2007-01-16 22:07 ` Michael Buesch
2007-01-16 23:51 ` Pavel Roskin
2007-01-17 9:52 ` Michael Buesch
2007-01-18 9:41 ` Pavel Roskin
2007-01-19 7:54 ` Pavel Roskin
2007-01-22 20:06 ` Michael Buesch
2007-01-22 20:44 ` Pavel Roskin
2007-01-22 21:00 ` Michael Buesch
2007-01-22 22:04 ` Larry Finger
2007-01-23 6:14 ` Pavel Roskin
2007-01-23 9:21 ` Michael Buesch
[not found] ` <200701231021.34995.mb-fseUSCV1ubazQB+pC5nmwQ@public.gmane.org>
2007-01-24 5:43 ` Pavel Roskin
2007-01-24 8:43 ` Michael Buesch [this message]
2007-01-16 19:00 ` Andreas Schwab
2007-01-16 19:24 ` Michael Buesch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200701240943.24141.mb@bu3sch.de \
--to=mb@bu3sch.de \
--cc=bcm43xx-dev@lists.berlios.de \
--cc=netdev@vger.kernel.org \
--cc=proski@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).