From: David Miller <davem@davemloft.net>
To: baruch@ev-en.org
Cc: netdev@vger.kernel.org, shemminger@osdl.org
Subject: Re: [PATCH] Fix sorting of SACK blocks
Date: Thu, 25 Jan 2007 15:55:32 -0800 (PST) [thread overview]
Message-ID: <20070125.155532.78711708.davem@davemloft.net> (raw)
In-Reply-To: <20070125182903.GA22455@galon.ev-en.org>
From: Baruch Even <baruch@ev-en.org>
Date: Thu, 25 Jan 2007 20:29:03 +0200
> The sorting of SACK blocks actually munges them rather than sort, causing the
> TCP stack to ignore some SACK information and breaking the assumption of
> ordered SACK blocks after sorting.
>
> The sort takes the data from a second buffer which isn't moved causing
> subsequent data moves to occur from the wrong location. The fix is to
> use a temporary buffer as a normal sort does.
>
> Signed-Off-By: Baruch Even <baruch@ev-en.org>
BTW, in reviewing this I note that there is now only one remaining
use of tp->recv_sack_cache[] and that is the code earlier in this
function which is trying to detect if all we are doing is extending
the leading edge of a SACK block.
It would be nice to be able to clear out that usage as well, and
remove recv_sack_cache[] and thus make tcp_sock smaller.
next prev parent reply other threads:[~2007-01-25 23:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-25 18:29 [PATCH] Fix sorting of SACK blocks Baruch Even
2007-01-25 18:36 ` Stephen Hemminger
2007-01-25 19:08 ` Baruch Even
2007-01-25 21:34 ` David Miller
2007-01-25 23:55 ` David Miller [this message]
2007-01-26 6:40 ` Baruch Even
2007-01-26 8:42 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070125.155532.78711708.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=baruch@ev-en.org \
--cc=netdev@vger.kernel.org \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).