netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: ebiederm@xmission.com
Cc: Robert.Olsson@data.slu.se, netdev@vger.kernel.org,
	robert.olsson@its.uu.se
Subject: Re: [PATCH] net: Fix the fib trie iterator to work with a single entry routing tables
Date: Fri, 26 Jan 2007 19:06:34 -0800 (PST)	[thread overview]
Message-ID: <20070126.190634.85416088.davem@davemloft.net> (raw)
In-Reply-To: <m1veitvlpa.fsf@ebiederm.dsl.xmission.com>

From: ebiederm@xmission.com (Eric W. Biederman)
Date: Fri, 26 Jan 2007 08:42:25 -0700

> Robert Olsson <Robert.Olsson@data.slu.se> writes:
> 
> > David Miller writes:
> >
> >  > > Yes the case when the trie is just a single leaf got wrong with the
> >  > > iterator and your patchs cures it. I think we have a similar problem
> >  > > with /proc/net/fib_trie
> >  > 
> >  > I'm happy to review a fix for that :-)
> >  
> > When main table is just a single leaf this gets printed as belonging to the 
> > local table in /proc/net/fib_trie. A fix is below.
> 
> Good spotting.  I was happy the data was showing up, I missed we that we put
> the meta information was wrong.
> 
> Looks good to me.

To me too, applied.

Thanks!

      reply	other threads:[~2007-01-27  3:06 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-24 19:56 [PATCH] net: Fix the fib trie iterator to work with a single entry routing tables Eric W. Biederman
2007-01-24 21:43 ` Robert Olsson
2007-01-24 22:42   ` David Miller
2007-01-25  2:11     ` Eric W. Biederman
2007-01-26 12:56     ` Robert Olsson
2007-01-26 15:42       ` Eric W. Biederman
2007-01-27  3:06         ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070126.190634.85416088.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=Robert.Olsson@data.slu.se \
    --cc=ebiederm@xmission.com \
    --cc=netdev@vger.kernel.org \
    --cc=robert.olsson@its.uu.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).