From: Jarek Poplawski <jarkao2@o2.pl>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Masayuki Nakagawa <nakagawa.msy@ncos.nec.co.jp>,
davem@davemloft.net, yoshfuji@linux-ipv6.org, mhuth@mvista.com,
netdev@vger.kernel.org
Subject: Re: [PATCH] TCP: Replace __kfree_skb() with kfree_skb()
Date: Fri, 26 Jan 2007 10:49:50 +0100 [thread overview]
Message-ID: <20070126094950.GB1639@ff.dom.local> (raw)
In-Reply-To: <20070126091606.GA23469@gondor.apana.org.au>
On Fri, Jan 26, 2007 at 08:16:06PM +1100, Herbert Xu wrote:
> On Fri, Jan 26, 2007 at 09:28:38AM +0100, Jarek Poplawski wrote:
> >
> > So maybe for some time there should be added skb->users
> > test with a warning to reveal this?
>
> Or just replace __kfree_skb by kfree_skb. The atomic operation (the
> expensive part of kfree_skb vs. __kfree_skb) is only taken when it
> is needed.
But:
> This change might reveals a memory leak of skb.
> If it happens, it would be because someone doesn't deal with the skb properly.
How do we know about those improper deals?
I understand there should be no other users here
if it's __kfree_skb now. So I mean to test and warn
before kfree_skb for some debugging time.
Jarek P.
next prev parent reply other threads:[~2007-01-26 9:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-26 3:37 [PATCH] TCP: Replace __kfree_skb() with kfree_skb() Masayuki Nakagawa
2007-01-26 8:28 ` Jarek Poplawski
2007-01-26 9:16 ` Herbert Xu
2007-01-26 9:49 ` Jarek Poplawski [this message]
2007-01-26 9:52 ` Herbert Xu
2007-01-26 10:18 ` Jarek Poplawski
2007-01-26 10:45 ` Herbert Xu
2007-01-26 10:58 ` David Miller
2007-01-26 11:02 ` Jarek Poplawski
2007-01-26 13:18 ` Jarek Poplawski
2007-01-26 14:05 ` Jarek Poplawski
2007-01-26 14:19 ` Alexey Kuznetsov
2007-01-29 8:26 ` Jarek Poplawski
2007-01-29 10:38 ` Jarek Poplawski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070126094950.GB1639@ff.dom.local \
--to=jarkao2@o2.pl \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=mhuth@mvista.com \
--cc=nakagawa.msy@ncos.nec.co.jp \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).