From: Jarek Poplawski <jarkao2@o2.pl>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Masayuki Nakagawa <nakagawa.msy@ncos.nec.co.jp>,
davem@davemloft.net, yoshfuji@linux-ipv6.org, mhuth@mvista.com,
netdev@vger.kernel.org, Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>
Subject: Re: [PATCH] TCP: Replace __kfree_skb() with kfree_skb()
Date: Fri, 26 Jan 2007 12:02:35 +0100 [thread overview]
Message-ID: <20070126110235.GD1639@ff.dom.local> (raw)
In-Reply-To: <20070126104518.GA24490@gondor.apana.org.au>
On Fri, Jan 26, 2007 at 09:45:18PM +1100, Herbert Xu wrote:
> On Fri, Jan 26, 2007 at 11:18:38AM +0100, Jarek Poplawski wrote:
> >
> > I don't mean it's necessary. I mean now skb is freed
> > unconditionally and after this patch, if there is some
> > error in counting, skb will stay. I thought Masayuki
> > wrote about such possibility, but if I missed his
> > point, then the rest is really O.K.
>
> OK, I see what you mean.
>
> I'm not aware of anybody who has coded in this way. Alexey & Dave,
> do you know of any place where __kfree_skb is used to free an skb
> whose ref count is greater than 1?
I'm sure it wasn't done on purpose! But it could hide
some errors anyway.
Jarek P.
next prev parent reply other threads:[~2007-01-26 11:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-26 3:37 [PATCH] TCP: Replace __kfree_skb() with kfree_skb() Masayuki Nakagawa
2007-01-26 8:28 ` Jarek Poplawski
2007-01-26 9:16 ` Herbert Xu
2007-01-26 9:49 ` Jarek Poplawski
2007-01-26 9:52 ` Herbert Xu
2007-01-26 10:18 ` Jarek Poplawski
2007-01-26 10:45 ` Herbert Xu
2007-01-26 10:58 ` David Miller
2007-01-26 11:02 ` Jarek Poplawski [this message]
2007-01-26 13:18 ` Jarek Poplawski
2007-01-26 14:05 ` Jarek Poplawski
2007-01-26 14:19 ` Alexey Kuznetsov
2007-01-29 8:26 ` Jarek Poplawski
2007-01-29 10:38 ` Jarek Poplawski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070126110235.GD1639@ff.dom.local \
--to=jarkao2@o2.pl \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=kuznet@ms2.inr.ac.ru \
--cc=mhuth@mvista.com \
--cc=nakagawa.msy@ncos.nec.co.jp \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).