From: David Miller <davem@davemloft.net>
To: bunk@stusta.de
Cc: randy.dunlap@oracle.com, akpm@osdl.org,
linux-kernel@vger.kernel.org, netfilter@lists.netfilter.org,
netdev@vger.kernel.org
Subject: Re: [2.6 patch] NF_CONNTRACK_H323 must depend on (IPV6 || IPV6=n)
Date: Sun, 28 Jan 2007 15:53:48 -0800 (PST) [thread overview]
Message-ID: <20070128.155348.39160134.davem@davemloft.net> (raw)
In-Reply-To: <20070128222136.GZ6017@stusta.de>
From: Adrian Bunk <bunk@stusta.de>
Date: Sun, 28 Jan 2007 23:21:37 +0100
> On Sun, Jan 28, 2007 at 11:41:48AM -0800, Randy Dunlap wrote:
> >...
> > net/built-in.o: In function `q931_help':
> > nf_conntrack_h323_main.c:(.text.q931_help+0x6ad): undefined reference to `ip6_route_output'
> > nf_conntrack_h323_main.c:(.text.q931_help+0x6c3): undefined reference to `ip6_route_output'
> >...
>
> You didn't send your .config, but it seems you had CONFIG_IPV6=m and
> CONFIG_NF_CONNTRACK_H323=y.
>
> In this case, the untested patch below should fix it.
>
> > ~Randy
>
> cu
> Adrian
>
>
> <-- snip -->
>
>
> CONFIG_IPV6=m, CONFIG_NF_CONNTRACK_H323=y results in a compile error.
>
> Fix this by letting NF_CONNTRACK_H323 depend on (IPV6 || IPV6=n).
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
Adrian is this the correct way to constrain the selection between
"n" and "m" in this kind of situation? I thought doing something
like "depends on IPV6" is sufficient to achieve that?
next prev parent reply other threads:[~2007-01-28 23:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20070127234928.64d8e437.akpm@osdl.org>
[not found] ` <20070128114148.b8067721.randy.dunlap@oracle.com>
2007-01-28 22:21 ` [2.6 patch] NF_CONNTRACK_H323 must depend on (IPV6 || IPV6=n) Adrian Bunk
2007-01-28 23:53 ` David Miller [this message]
2007-01-29 0:00 ` Adrian Bunk
2007-01-29 0:04 ` David Miller
2007-01-29 0:21 ` Adrian Bunk
2007-01-29 1:22 ` Randy Dunlap
2007-01-30 17:13 ` Patrick McHardy
2007-01-28 22:31 ` 2.6.20-rc6-mm1 Michal Piotrowski
2007-01-28 23:10 ` 2.6.20-rc6-mm1 Andrew Morton
2007-01-29 5:17 ` 2.6.20-rc6-mm1 Herbert Xu
2007-01-29 5:29 ` 2.6.20-rc6-mm1 Herbert Xu
2007-01-29 6:43 ` 2.6.20-rc6-mm1 Andrew Morton
2007-01-29 7:21 ` 2.6.20-rc6-mm1 Herbert Xu
2007-01-29 8:35 ` 2.6.20-rc6-mm1 Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070128.155348.39160134.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@osdl.org \
--cc=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter@lists.netfilter.org \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).