From: David Miller <davem@davemloft.net>
To: herbert@gondor.apana.org.au
Cc: baruch@ev-en.org, netdev@vger.kernel.org
Subject: Re: [PATCH 2/3] Seperate DSACK from SACK fast path
Date: Sun, 28 Jan 2007 21:28:51 -0800 (PST) [thread overview]
Message-ID: <20070128.212851.31444923.davem@davemloft.net> (raw)
In-Reply-To: <E1HBOiV-0007bt-00@gondolin.me.apana.org.au>
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Mon, 29 Jan 2007 16:06:07 +1100
> Baruch Even <baruch@ev-en.org> wrote:
> >>
> >> > Since the SACK receive cache doesn't need the data to be in host
> >> > order we also remove the ntohl in the checking loop.
> >> ...
> >> > - for (i = 0; i< num_sacks; i++) {
> >> > - __u32 start_seq = ntohl(sp[i].start_seq);
> >> > - __u32 end_seq = ntohl(sp[i].end_seq);
> >> > + for (i = 0; i < num_sacks; i++) {
> >> > + __u32 start_seq = sp[i].start_seq;
> >> > + __u32 end_seq = sp[i].end_seq;
> >
> > Yes. The only comparison we do with recv_sack_cache entries is != and
> > that works for net-endian just fine.
>
> In that case you need to use __be32 before Al Viro starts coming after
> you :)
Good catch, Baruch please fix this up :-)
next prev parent reply other threads:[~2007-01-29 5:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-27 16:47 [PATCH 0/3] Fix issues with SACK processing Baruch Even
2007-01-27 16:48 ` [PATCH 1/3] Advance fast path pointer for first block only Baruch Even
2007-01-27 16:49 ` [PATCH 2/3] Seperate DSACK from SACK fast path Baruch Even
2007-01-28 4:06 ` David Miller
2007-01-28 5:27 ` Baruch Even
2007-01-29 5:06 ` Herbert Xu
2007-01-29 5:28 ` David Miller [this message]
2007-01-27 16:50 ` [PATCH 3/3] Check num sacks in " Baruch Even
[not found] <20070129071339.24050.21052.sendpatchset@galon.ev-en.org>
[not found] ` <20070129071344.24050.14971.sendpatchset@galon.ev-en.org>
2007-01-31 20:49 ` [PATCH 2/3] Seperate DSACK from " David Miller
[not found] <20070202144116.26863.3722.sendpatchset@galon.ev-en.org>
[not found] ` <20070202144121.26863.90947.sendpatchset@galon.ev-en.org>
2007-02-05 7:36 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070128.212851.31444923.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=baruch@ev-en.org \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).