From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adrian Bunk Subject: Re: [2.6 patch] NF_CONNTRACK_H323 must depend on (IPV6 || IPV6=n) Date: Mon, 29 Jan 2007 01:21:08 +0100 Message-ID: <20070129002108.GC6017@stusta.de> References: <20070128222136.GZ6017@stusta.de> <20070128.155348.39160134.davem@davemloft.net> <20070129000011.GB6017@stusta.de> <20070128.160442.48527586.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: randy.dunlap@oracle.com, akpm@osdl.org, linux-kernel@vger.kernel.org, netfilter@lists.netfilter.org, netdev@vger.kernel.org, kaber@trash.net To: David Miller Return-path: Received: from mailout.stusta.mhn.de ([141.84.69.5]:42814 "EHLO mailhub.stusta.mhn.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S933002AbXA2AVA (ORCPT ); Sun, 28 Jan 2007 19:21:00 -0500 Content-Disposition: inline In-Reply-To: <20070128.160442.48527586.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Sun, Jan 28, 2007 at 04:04:42PM -0800, David Miller wrote: > From: Adrian Bunk > Date: Mon, 29 Jan 2007 01:00:11 +0100 > > > On Sun, Jan 28, 2007 at 03:53:48PM -0800, David Miller wrote: > > > Adrian is this the correct way to constrain the selection between > > > "n" and "m" in this kind of situation? I thought doing something > > > like "depends on IPV6" is sufficient to achieve that? > > > > "depends on IPV6" would fix the bug - but it would also make > > NF_CONNTRACK_H323 unavailable for all people without IPV6 support in > > their kernel. > > Yes, that is an issue. > > I guess with some slightly ugly ifdefs we could support the > whole matrix of possibilities. But perhaps that's undesirable > for another reason. >... This depends on what NF_CONNTRACK_H323=y, IPV6=m is supposed to be: - not allowed (NF_CONNTRACK_H323 must be modular) or - NF_CONNTRACK_H323 can only be used for IPV4 My patch implements the first case. cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed