2.6.20-rc6: known unfixed regressions (part 2)

2.6.20-rc6: known unfixed regressions (part 2)

[Adrian Bunk]

This email lists some known regressions in 2.6.20-rc6 compared to 2.6.19
that are not yet fixed in Linus' tree.

If you find your name in the Cc header, you are either submitter of one
of the bugs, maintainer of an affectected subsystem or driver, a patch
of you caused a breakage or I'm considering you in any other way possibly
involved with one or more of these issues.

Due to the huge amount of recipients, please trim the Cc when answering.


Subject    : problems with CD burning
References : http://www.spinics.net/lists/linux-ide/msg06545.html
Submitter  : Uwe Bugla <uwe.bugla@gmx.de>
Status     : unknown


Subject    : pktcdvd fails with pata_amd
References : http://bugzilla.kernel.org/show_bug.cgi?id=7810
             http://lkml.org/lkml/2007/1/25/128
Submitter  : Gerhard Dirschl <gd@spherenet.de>
Caused-By  : Christoph Hellwig <hch@lst.de>
             commit 406c9b605cbc45151c03ac9a3f95e9acf050808c
             commit 3b00315799d78f76531b71435fbc2643cd71ae4c
Status     : problem is being debugged


Subject    : SELinux compile error with CONFIG_XFRM=n
References : http://lkml.org/lkml/2007/1/25/233
Submitter  : Michal Piotrowski <michal.k.k.piotrowski@gmail.com>
Caused-By  : Venkat Yekkirala <vyekkirala@TrustedCS.com>
             commit 334c85569b8adeaa820c0f2fab3c8f0a9dc8b92e
Handled-By : Venkat Yekkirala <vyekkirala@TrustedCS.com>
             David Miller <davem@davemloft.net>
Status     : problem is being discussed


Subject    : powerpc64: performance monitor exception
References : http://ozlabs.org/pipermail/linuxppc-dev/2007-January/030045.html
Submitter  : Livio Soares <livio@eecg.toronto.edu>
Caused-By  : Paul Mackerras <paulus@samba.org>
             commit d04c56f73c30a5e593202ecfcf25ed43d42363a2
Status     : problem is being discussed


Subject    : BUG: at fs/inotify.c:172 set_dentry_child_flags()
References : http://bugzilla.kernel.org/show_bug.cgi?id=7785
Submitter  : Cijoml Cijomlovic Cijomlov <cijoml@volny.cz>
Handled-By : Nick Piggin <nickpiggin@yahoo.com.au>
Status     : problem is being debugged


Subject    : BUG: at mm/truncate.c:60 cancel_dirty_page()  (reiserfs)
References : http://lkml.org/lkml/2007/1/7/117
             http://lkml.org/lkml/2007/1/10/202
Submitter  : Malte Schröder <MalteSch@gmx.de>
Handled-By : Vladimir V. Saveliev <vs@namesys.com>
             Nick Piggin <nickpiggin@yahoo.com.au>
Patch      : http://lkml.org/lkml/2007/1/10/202
Status     : problem is being discussed


Subject    : BUG: at mm/truncate.c:60 cancel_dirty_page()  (XFS)
References : http://lkml.org/lkml/2007/1/5/308
             http://lkml.org/lkml/2007/1/23/190
             http://lkml.org/lkml/2007/1/23/192
Submitter  : Sami Farin <7atbggg02@sneakemail.com>
Handled-By : David Chinner <dgc@sgi.com>
Status     : patches are being discussed

Re: 2.6.20-rc6: known unfixed regressions (part 2)

[Michal Piotrowski]

Hi,

Adrian Bunk napisał(a):
> This email lists some known regressions in 2.6.20-rc6 compared to 2.6.19
> that are not yet fixed in Linus' tree.
> 
> If you find your name in the Cc header, you are either submitter of one
> of the bugs, maintainer of an affectected subsystem or driver, a patch
> of you caused a breakage or I'm considering you in any other way possibly
> involved with one or more of these issues.
> 
> Due to the huge amount of recipients, please trim the Cc when answering.
> 
> 
> Subject    : SELinux compile error with CONFIG_XFRM=n
> References : http://lkml.org/lkml/2007/1/25/233
> Submitter  : Michal Piotrowski <michal.k.k.piotrowski@gmail.com>
> Caused-By  : Venkat Yekkirala <vyekkirala@TrustedCS.com>
>              commit 334c85569b8adeaa820c0f2fab3c8f0a9dc8b92e
> Handled-By : Venkat Yekkirala <vyekkirala@TrustedCS.com>
>              David Miller <davem@davemloft.net>
> Status     : problem is being discussed
> 

Venkat Yekkirala has sent me a patch that fixed this build problem.

Thanks!

Regards,
Michal

-- 
Michal K. K. Piotrowski
LTG - Linux Testers Group
(http://www.stardust.webpages.pl/ltg/)

RE: 2.6.20-rc6: known unfixed regressions (part 2)

[Venkat Yekkirala]

FYI- The patch can be viewed here:

http://marc.theaimsgroup.com/?l=linux-netdev&m=116983297300536&w=2

> -----Original Message-----
> From: Michal Piotrowski [mailto:michal.k.k.piotrowski@gmail.com]
> Sent: Friday, January 26, 2007 1:04 PM
> To: Adrian Bunk
> Cc: Linus Torvalds; Andrew Morton; Linux Kernel Mailing List; 
> Uwe Bugla;
> B.Zolnierkiewicz@elka.pw.edu.pl; linux-ide@vger.kernel.org;
> alan@lxorguk.ukuu.org.uk; Gerhard Dirschl; Christoph Hellwig;
> petero2@telia.com; Michal Piotrowski; Venkat Yekkirala; David Miller;
> sds@tycho.nsa.gov; jmorris@namei.org; netdev@vger.kernel.org; Livio
> Soares; Paul Mackerras; linuxppc-dev@ozlabs.org; Cijoml Cijomlovic
> Cijomlov; Nick Piggin; ttb@tentacle.dhs.org; rml@novell.com; Malte
> Schröder; Vladimir V. Saveliev; reiserfs-dev@namesys.com; Sami Farin;
> David Chinner; xfs-masters@oss.sgi.com
> Subject: Re: 2.6.20-rc6: known unfixed regressions (part 2)
> 
> 
> Hi,
> 
> Adrian Bunk napisał(a):
> > This email lists some known regressions in 2.6.20-rc6 
> compared to 2.6.19
> > that are not yet fixed in Linus' tree.
> > 
> > If you find your name in the Cc header, you are either 
> submitter of one
> > of the bugs, maintainer of an affectected subsystem or 
> driver, a patch
> > of you caused a breakage or I'm considering you in any 
> other way possibly
> > involved with one or more of these issues.
> > 
> > Due to the huge amount of recipients, please trim the Cc 
> when answering.
> > 
> > 
> > Subject    : SELinux compile error with CONFIG_XFRM=n
> > References : http://lkml.org/lkml/2007/1/25/233
> > Submitter  : Michal Piotrowski <michal.k.k.piotrowski@gmail.com>
> > Caused-By  : Venkat Yekkirala <vyekkirala@TrustedCS.com>
> >              commit 334c85569b8adeaa820c0f2fab3c8f0a9dc8b92e
> > Handled-By : Venkat Yekkirala <vyekkirala@TrustedCS.com>
> >              David Miller <davem@davemloft.net>
> > Status     : problem is being discussed
> > 
> 
> Venkat Yekkirala has sent me a patch that fixed this build problem.
> 
> Thanks!
> 
> Regards,
> Michal
> 
> -- 
> Michal K. K. Piotrowski
> LTG - Linux Testers Group
> (http://www.stardust.webpages.pl/ltg/)
> 

[PATCH] block MSI on Sony

[Stephen Hemminger]

The Sony VAIO BIOS resets to INTx on resume. This happens
after device resume, so device irq's get misrouted.

This hack turns off MSI on this laptop, until power management
initialization order is fixed.

Signed-off-by: Stephen Hemminger <shemminger@linux-foundation.org>

---
 drivers/pci/quirks.c |   32 ++++++++++++++++++++++++++++++++
 1 files changed, 32 insertions(+), 0 deletions(-)

diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
index ef882a8..9a64179 100644
--- a/drivers/pci/quirks.c
+++ b/drivers/pci/quirks.c
@@ -21,6 +21,7 @@ #include <linux/pci.h>
 #include <linux/init.h>
 #include <linux/delay.h>
 #include <linux/acpi.h>
+#include <linux/dmi.h>
 #include "pci.h"
 
 /* The Mellanox Tavor device gives false positive parity errors
@@ -1779,6 +1780,37 @@ static void __devinit quirk_nvidia_ck804
 }
 DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_NVIDIA, PCI_DEVICE_ID_NVIDIA_CK804_PCIE,
 			quirk_nvidia_ck804_msi_ht_cap);
+
+/* On Sony VAIO laptop, BIOS resets MSI during resume. */
+static __initdata struct dmi_system_id sony_dmi_table[] = {
+	{
+		.ident = "Sony Vaio",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "Sony Corporation"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "PCG-"),
+		},
+	},
+	{
+		.ident = "Sony Vaio",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "Sony Corporation"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "VGN-"),
+		},
+	},
+	{ }
+};
+
+static void __init quirk_sony_msi(struct pci_dev *dev)
+{
+	if (!dmi_check_system(sony_dmi_table))
+		return;
+
+	pci_msi_quirk = 1;
+	printk(KERN_WARNING "PCI: MSI sony quirk detected. pci_msi_quirk set.\n");
+}
+DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_82801BA_6,
+			quirk_sony_msi);
+
 #endif /* CONFIG_PCI_MSI */
 
 EXPORT_SYMBOL(pcie_mch_quirk);
-- 
1.4.1

Re: [PATCH] block MSI on Sony

[Thomas Gleixner]

On Mon, 2007-01-29 at 15:50 -0800, Stephen Hemminger wrote:
> The Sony VAIO BIOS resets to INTx on resume. This happens
> after device resume, so device irq's get misrouted.

Err? My Sony VAIO does _NOT_ do that. It works fine without that. 
It's just the sky2 hackery which fucked up things.

	tglx


	

Re: [PATCH] block MSI on Sony

[Stephen Hemminger]

On Tue, 30 Jan 2007 01:22:54 +0100
Thomas Gleixner <tglx@linutronix.de> wrote:

> On Mon, 2007-01-29 at 15:50 -0800, Stephen Hemminger wrote:
> > The Sony VAIO BIOS resets to INTx on resume. This happens
> > after device resume, so device irq's get misrouted.
> 
> Err? My Sony VAIO does _NOT_ do that. It works fine without that. 
> It's just the sky2 hackery which fucked up things.
> 

What machine and BIOS version?


-- 
Stephen Hemminger <shemminger@linux-foundation.org>

Re: [PATCH] block MSI on Sony

[Thomas Gleixner]

On Mon, 2007-01-29 at 16:21 -0800, Stephen Hemminger wrote:
> > > The Sony VAIO BIOS resets to INTx on resume. This happens
> > > after device resume, so device irq's get misrouted.
> > 
> > Err? My Sony VAIO does _NOT_ do that. It works fine without that. 
> > It's just the sky2 hackery which fucked up things.
> 
> What machine and BIOS version?

VGN-SZ2XP_C
BIOS: R0081N0

	tglx

Re: [PATCH] block MSI on Sony

[Stephen Hemminger]

On Tue, 30 Jan 2007 01:31:33 +0100
Thomas Gleixner <tglx@linutronix.de> wrote:

> On Mon, 2007-01-29 at 16:21 -0800, Stephen Hemminger wrote:
> > > > The Sony VAIO BIOS resets to INTx on resume. This happens
> > > > after device resume, so device irq's get misrouted.
> > > 
> > > Err? My Sony VAIO does _NOT_ do that. It works fine without that. 
> > > It's just the sky2 hackery which fucked up things.
> > 
> > What machine and BIOS version?
> 
> VGN-SZ2XP_C
> BIOS: R0081N0

Mine is:
	VGN-N170G
	BIOS: R0020J4

It might be BIOS bug that has been fixed, but updating the
BIOS requires Windows. It checks for some ID so even Wine
won't work.


-- 
Stephen Hemminger <shemminger@linux-foundation.org>

Re: [PATCH] block MSI on Sony

[Thomas Gleixner]

On Tue, 2007-01-30 at 01:22 +0100, Thomas Gleixner wrote:
> On Mon, 2007-01-29 at 15:50 -0800, Stephen Hemminger wrote:
> > The Sony VAIO BIOS resets to INTx on resume. This happens
> > after device resume, so device irq's get misrouted.
> 
> Err? My Sony VAIO does _NOT_ do that. It works fine without that. 
> It's just the sky2 hackery which fucked up things.

And how is this going to solve the breakage on Frederics box?

> I see the same symptoms on my Intel Mac Mini, and reverting the commit
> also allows the driver to seemingly resume correctly. 

Still it stands: 

Your sky2 patch #44ade178249fe53d055fd92113eaa271e06acddd is broken.

Just get it.

	tglx

[PATCH] sky2: revert IRQ dance on suspend/resume

[Stephen Hemminger]

Let's just backout the IRQ hack, and for those crap machines
(like some Sony VAIO's) can just disable MSI with the module
parameter.

Signed-off-by: Stephen Hemminger <shemminger@sony-laptop.(none)>
---
 drivers/net/sky2.c |   25 -------------------------
 1 files changed, 0 insertions(+), 25 deletions(-)

diff --git a/drivers/net/sky2.c b/drivers/net/sky2.c
index a2e804d..822dd0b 100644
--- a/drivers/net/sky2.c
+++ b/drivers/net/sky2.c
@@ -3639,29 +3639,6 @@ static int sky2_resume(struct pci_dev *p
 out:
 	return err;
 }
-
-/* BIOS resume runs after device (it's a bug in PM)
- * as a temporary workaround on suspend/resume leave MSI disabled
- */
-static int sky2_suspend_late(struct pci_dev *pdev, pm_message_t state)
-{
-	struct sky2_hw *hw = pci_get_drvdata(pdev);
-
-	free_irq(pdev->irq, hw);
-	if (hw->msi) {
-		pci_disable_msi(pdev);
-		hw->msi = 0;
-	}
-	return 0;
-}
-
-static int sky2_resume_early(struct pci_dev *pdev)
-{
-	struct sky2_hw *hw = pci_get_drvdata(pdev);
-	struct net_device *dev = hw->dev[0];
-
-	return request_irq(pdev->irq, sky2_intr, IRQF_SHARED, dev->name, hw);
-}
 #endif
 
 static struct pci_driver sky2_driver = {
@@ -3672,8 +3649,6 @@ static struct pci_driver sky2_driver = {
 #ifdef CONFIG_PM
 	.suspend = sky2_suspend,
 	.resume = sky2_resume,
-	.suspend_late = sky2_suspend_late,
-	.resume_early = sky2_resume_early,
 #endif
 };
 
-- 
1.4.1

Re: [PATCH] sky2: revert IRQ dance on suspend/resume

[Linus Torvalds]

On Mon, 29 Jan 2007, Stephen Hemminger wrote:
> 
> Signed-off-by: Stephen Hemminger <shemminger@sony-laptop.(none)>

Mind if I fix your sign-off? ;)

		Linus

Re: [PATCH] sky2: revert IRQ dance on suspend/resume

[Stephen Hemminger]

On Mon, 29 Jan 2007 16:43:04 -0800 (PST)
Linus Torvalds <torvalds@linux-foundation.org> wrote:

> 
> 
> On Mon, 29 Jan 2007, Stephen Hemminger wrote:
> > 
> > Signed-off-by: Stephen Hemminger <shemminger@sony-laptop.(none)>
> 
> Mind if I fix your sign-off? ;)
> 
> 		Linus

Sorry, that was the test machine...


-- 
Stephen Hemminger <shemminger@linux-foundation.org>