netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Hemminger <shemminger@linux-foundation.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: netdev@vger.kernel.org, Jeff Garzik <jeff@garzik.org>
Subject: [PATCH] sky2: revert IRQ dance on suspend/resume
Date: Mon, 29 Jan 2007 16:38:07 -0800	[thread overview]
Message-ID: <20070129163807.49739750@freekitty> (raw)
In-Reply-To: <Pine.LNX.4.64.0701291623360.3611@woody.linux-foundation.org>

Let's just backout the IRQ hack, and for those crap machines
(like some Sony VAIO's) can just disable MSI with the module
parameter.

Signed-off-by: Stephen Hemminger <shemminger@sony-laptop.(none)>
---
 drivers/net/sky2.c |   25 -------------------------
 1 files changed, 0 insertions(+), 25 deletions(-)

diff --git a/drivers/net/sky2.c b/drivers/net/sky2.c
index a2e804d..822dd0b 100644
--- a/drivers/net/sky2.c
+++ b/drivers/net/sky2.c
@@ -3639,29 +3639,6 @@ static int sky2_resume(struct pci_dev *p
 out:
 	return err;
 }
-
-/* BIOS resume runs after device (it's a bug in PM)
- * as a temporary workaround on suspend/resume leave MSI disabled
- */
-static int sky2_suspend_late(struct pci_dev *pdev, pm_message_t state)
-{
-	struct sky2_hw *hw = pci_get_drvdata(pdev);
-
-	free_irq(pdev->irq, hw);
-	if (hw->msi) {
-		pci_disable_msi(pdev);
-		hw->msi = 0;
-	}
-	return 0;
-}
-
-static int sky2_resume_early(struct pci_dev *pdev)
-{
-	struct sky2_hw *hw = pci_get_drvdata(pdev);
-	struct net_device *dev = hw->dev[0];
-
-	return request_irq(pdev->irq, sky2_intr, IRQF_SHARED, dev->name, hw);
-}
 #endif
 
 static struct pci_driver sky2_driver = {
@@ -3672,8 +3649,6 @@ static struct pci_driver sky2_driver = {
 #ifdef CONFIG_PM
 	.suspend = sky2_suspend,
 	.resume = sky2_resume,
-	.suspend_late = sky2_suspend_late,
-	.resume_early = sky2_resume_early,
 #endif
 };
 
-- 
1.4.1


  parent reply	other threads:[~2007-01-30  0:40 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <Pine.LNX.4.64.0701241847360.25027@woody.linux-foundation.org>
2007-01-26 18:11 ` 2.6.20-rc6: known unfixed regressions (part 2) Adrian Bunk
2007-01-26 19:04   ` Michal Piotrowski
2007-01-26 19:08     ` Venkat Yekkirala
     [not found] ` <1169931333.17469.125.camel@localhost.localdomain>
     [not found]   ` <20070129113159.7ad22e4c@freekitty>
     [not found]     ` <1170101430.29240.34.camel@localhost.localdomain>
     [not found]       ` <20070129133849.1b523226@freekitty>
     [not found]         ` <1170109401.29240.49.camel@localhost.localdomain>
     [not found]           ` <1170110318.21603.25.camel@funkylaptop>
     [not found]             ` <1170110732.29240.59.camel@localhost.localdomain>
     [not found]               ` <1170111056.21603.30.camel@funkylaptop>
     [not found]                 ` <1170111464.29240.63.camel@localhost.localdomain>
     [not found]                   ` <1170113200.21603.41.camel@funkylaptop>
     [not found]                     ` <1170113879.29240.79.camel@localhost.localdomain>
2007-01-29 23:50                       ` [PATCH] block MSI on Sony Stephen Hemminger
2007-01-30  0:22                         ` Thomas Gleixner
2007-01-30  0:21                           ` Stephen Hemminger
2007-01-30  0:31                             ` Thomas Gleixner
2007-01-30  0:31                               ` Stephen Hemminger
2007-01-30  0:26                           ` Thomas Gleixner
     [not found]           ` <Pine.LNX.4.64.0701291431320.3611@woody.linux-foundation.org>
     [not found]             ` <20070129144055.151cfe52@freekitty>
     [not found]               ` <Pine.LNX.4.64.0701291501180.3611@woody.linux-foundation.org>
     [not found]                 ` <20070129154518.40b0b3d3@freekitty>
     [not found]                   ` <Pine.LNX.4.64.0701291609180.3611@woody.linux-foundation.org>
     [not found]                     ` <20070129161626.33277eb1@freekitty>
     [not found]                       ` <Pine.LNX.4.64.0701291623360.3611@woody.linux-foundation.org>
2007-01-30  0:38                         ` Stephen Hemminger [this message]
2007-01-30  0:43                           ` [PATCH] sky2: revert IRQ dance on suspend/resume Linus Torvalds
2007-01-30  0:41                             ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070129163807.49739750@freekitty \
    --to=shemminger@linux-foundation.org \
    --cc=jeff@garzik.org \
    --cc=netdev@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).