From: David Miller <davem@davemloft.net>
To: jgarzik@pobox.com
Cc: netdev@vger.kernel.org, m.kozlowski@tuxland.pl, akpm@osdl.org,
torvalds@linux-foundation.org
Subject: Re: buggy IFB driver change
Date: Tue, 30 Jan 2007 14:12:40 -0800 (PST) [thread overview]
Message-ID: <20070130.141240.97296236.davem@davemloft.net> (raw)
In-Reply-To: <45BFBE1B.2040508@pobox.com>
From: Jeff Garzik <jgarzik@pobox.com>
Date: Tue, 30 Jan 2007 16:52:27 -0500
> David Miller wrote:
> > Jeff, please revert: 0c0b3ae68ec93b1db5c637d294647d1cca0df763
> >
> > It's wrong. We had a lengthy analysis of this piece of code
> > several months ago, and it is correct.
> >
> > Consider, if we run the loop and we get an error
> > the following happens:
> >
> > 1) attempt of ifb_init_one(i) fails, therefore we should
> > not try to "ifb_free_one()" on "i" since it failed
> > 2) the loop iteration first increments "i", then it
> > check for error
> >
> > Therefore we must decrement "i" twice before the first
> > free during the cleanup. One to "undo" the for() loop
> > increment, and one to "skip" the ifb_init_one() case which
> > failed.
> >
> > commit 0c0b3ae68ec93b1db5c637d294647d1cca0df763
> > Author: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
>
> Andrew and I both missed that thread, sorry.
>
> I'm about to crash, can you or Linus handle the correction?
Sure.
next prev parent reply other threads:[~2007-01-30 22:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-30 21:12 buggy IFB driver change David Miller
2007-01-30 21:52 ` Jeff Garzik
2007-01-30 22:12 ` David Miller [this message]
2007-01-31 0:24 ` Joe Perches
2007-01-30 22:13 ` Linus Torvalds
2007-01-30 22:21 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070130.141240.97296236.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@osdl.org \
--cc=jgarzik@pobox.com \
--cc=m.kozlowski@tuxland.pl \
--cc=netdev@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).