netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: olof@lixom.net (Olof Johansson)
To: Christoph Hellwig <hch@infradead.org>
Cc: jgarzik@pobox.com, netdev@vger.kernel.org
Subject: Re: [PATCH] PA Semi PWRficient Ethernet driver
Date: Tue, 30 Jan 2007 09:36:26 -0600	[thread overview]
Message-ID: <20070130153626.GB25309@lixom.net> (raw)
In-Reply-To: <20070130100358.GA8548@infradead.org>

On Tue, Jan 30, 2007 at 10:03:58AM +0000, Christoph Hellwig wrote:
> On Mon, Jan 29, 2007 at 12:08:52AM -0600, Olof Johansson wrote:
> > Driver for the PA Semi PWRficient on-chip Ethernet (1/10G)
> > 
> > Basic enablement, will be complemented with performance enhancements
> > over time. PHY support will be added as well.
> > 
> > This patch still uses the numerical PCI vendor id, it will be replaced
> > when the pci_ids.h change goes in (same as the other currently pending
> > drivers).
> 
> >From a quick glance over the code you don't seem to handle memory allocation
> erros at all, that needs some fixing.

v2 that I posted as a comment to the first one should have taken care
of most cases. I'll go through once more and see if I missed any before
posting a revised version later today.


Thanks,

-Olof

      reply	other threads:[~2007-01-30 15:29 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-29  6:08 [PATCH] PA Semi PWRficient Ethernet driver Olof Johansson
2007-01-29 18:22 ` Stephen Hemminger
2007-01-30  1:41   ` Olof Johansson
2007-01-30  2:34     ` Jeff Garzik
2007-01-30 20:53       ` Olof Johansson
2007-01-29 22:35 ` Francois Romieu
2007-01-30  1:41   ` Olof Johansson
2007-01-30 10:06     ` Christoph Hellwig
2007-01-30 15:34       ` Olof Johansson
2007-01-30 21:45     ` Francois Romieu
2007-01-31  4:52       ` Olof Johansson
2007-01-30  1:44 ` [PATCH] [v2]PA " Olof Johansson
2007-01-31  5:44   ` [PATCH] [v3] PA " Olof Johansson
2007-01-31 10:34     ` Jeff Garzik
2007-02-01  3:40       ` Olof Johansson
2007-01-31 12:44     ` Ingo Oeser
2007-01-31 15:16       ` Olof Johansson
2007-01-31 18:38     ` Stephen Hemminger
2007-02-01  3:20       ` Olof Johansson
2007-02-01  3:43     ` [PATCH] [v4] " Olof Johansson
2007-02-02 13:26       ` Jeff Garzik
2007-01-30 10:03 ` [PATCH] " Christoph Hellwig
2007-01-30 15:36   ` Olof Johansson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070130153626.GB25309@lixom.net \
    --to=olof@lixom.net \
    --cc=hch@infradead.org \
    --cc=jgarzik@pobox.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).