From: Jarek Poplawski <jarkao2@o2.pl>
To: Alexey Dobriyan <adobriyan@openvz.org>
Cc: David Stevens <dlstevens@us.ibm.com>,
davem@davemloft.net, kuznet@ms2.inr.ac.ru,
netdev@vger.kernel.org, netdev-owner@vger.kernel.org
Subject: Re: igmp: possible NULL dereference after GFP_ATOMIC allocation?
Date: Wed, 31 Jan 2007 10:39:09 +0100 [thread overview]
Message-ID: <20070131093909.GA2013@ff.dom.local> (raw)
In-Reply-To: <20070130150427.GB11121@localhost.sw.ru>
On 30-01-2007 16:04, Alexey Dobriyan wrote:
> On Tue, Jan 30, 2007 at 03:34:18AM -0800, David Stevens wrote:
>> I think you're correct-- looks like it needs:
>>
>> if (!skb)
>> return NULL;
>>
>> just before the skb_put(), since an allocation (and failure)
>> could occur in either the igmpv3_newpack() call or in add_grhead().
>> Also, similar code in net/ipv6/mcast..c.
>>
>> Will you be submitting the patch?
>
> One box here can semi-reliably reproduce oops which is attributed to
> these allocation failures. I'll tell if patch works or not soon.
I also think this "if" is needed there and hope you
are right but, actually, skb allocating errors
shouldn't be so semi-reliable.
I don't know what is the kernel version of this box,
but probably another reason could be in_device not
fully initialized, so you could check for David's
Stevens patch to devinet.c.
Regards,
Jarek P.
next prev parent reply other threads:[~2007-01-31 9:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-30 10:57 igmp: possible NULL dereference after GFP_ATOMIC allocation? Alexey Dobriyan
2007-01-30 11:34 ` David Stevens
2007-01-30 15:04 ` Alexey Dobriyan
2007-01-31 9:39 ` Jarek Poplawski [this message]
2007-02-05 15:04 ` [PATCH] igmp: check add_grhead() return value Alexey Dobriyan
2007-02-06 22:35 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070131093909.GA2013@ff.dom.local \
--to=jarkao2@o2.pl \
--cc=adobriyan@openvz.org \
--cc=davem@davemloft.net \
--cc=dlstevens@us.ibm.com \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev-owner@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).