Netdev List
 help / color / mirror / Atom feed
From: Shinta Sugimoto <shinta@sfc.wide.ad.jp>
To: usagi-core@linux-ipv6.org
Cc: netdev@vger.kernel.org,
	Francis Dupont <Francis.Dupont@point6.net>,
	Masahide Nakamura <nakam@linux-ipv6.org>
Subject: Re: (usagi-core 32165) Re: [RFC][PATCH][XFRM][4/5] extension to XFRM for dynamic endpoint update (MIGRATE)
Date: Fri, 02 Feb 2007 21:10:09 +0900	[thread overview]
Message-ID: <20070202210442.E2F9.SHINTA@sfc.wide.ad.jp> (raw)
In-Reply-To: <Pine.LNX.4.64.0702010947530.8524@d.namei>

On Thu, 1 Feb 2007 09:50:00 -0500 (EST)
James Morris <jmorris@namei.org> wrote:

> On Thu, 1 Feb 2007, Shinta Sugimoto wrote:
> 
> > +	/* allow IPSEC_PROTO_ANY to match all protocols */
> > +	//sel.proto = pfkey_proto_to_xfrm(sa->sadb_address_proto);
> > +	sel.proto = sa->sadb_address_proto;
> 
> Which one is correct ? :-)

Thank you for point this out.  The following should be correct.

sel.proto = pfkey_proto_to_xfrm(sa->sadb_address_proto);

> 
> > +	/* allow IPSEC_PROTO_ANY to match all protocols */
> > +	//sel.proto = pfkey_proto_to_xfrm(sa->sadb_address_proto);
> > +	sel.proto = sa->sadb_address_proto;
> 
> ...

Same for this one. I will fix them.


Regards,
Shinta


      reply	other threads:[~2007-02-02 12:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-01  4:10 [RFC][PATCH][XFRM][4/5] extension to XFRM for dynamic endpoint update (MIGRATE) Shinta Sugimoto
2007-02-01 14:50 ` James Morris
2007-02-02 12:10   ` Shinta Sugimoto [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070202210442.E2F9.SHINTA@sfc.wide.ad.jp \
    --to=shinta@sfc.wide.ad.jp \
    --cc=Francis.Dupont@point6.net \
    --cc=nakam@linux-ipv6.org \
    --cc=netdev@vger.kernel.org \
    --cc=usagi-core@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox