netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andi Kleen <ak@suse.de>
To: Rick Jones <rick.jones2@hp.com>
Cc: Linux Network Development list <netdev@vger.kernel.org>
Subject: Re: "meaningful" spinlock contention when bound to non-intr CPU?
Date: Fri, 2 Feb 2007 21:20:51 +0100	[thread overview]
Message-ID: <200702022120.52055.ak@suse.de> (raw)
In-Reply-To: <45C396E6.3080705@hp.com>


> Perhaps a poor choice of words on my part - something along the lines of:
> 
> hold_lock();
> wake_up_someone();
> release_lock();
> 
> where the someone being awoken can try to grab the lock before the path 
> doing the waking manages to release it.

Yes the wakeup happens deep inside the critical section and if the process
is running on another CPU it could race to the lock.

Hmm, i suppose the wakeup could be moved out, but it would need some restructuring
of the code. Also to be safe the code would still need to at least hold a 
reference count of the sock during the wakeup, and when that is released
then you have another cache line to bounce, which might not be any better
than the lock. So it might not be actually worth it.

I suppose the socket release could be at least partially protected with
RCU against this case so that could be done without a reference count, but 
it might be tricky to get this right.

Again still not sure it's worth handling this.

-Andi

  reply	other threads:[~2007-02-02 20:21 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-01 19:43 "meaningful" spinlock contention when bound to non-intr CPU? Rick Jones
2007-02-01 19:46 ` Rick Jones
2007-02-02 16:47 ` Jesse Brandeburg
2007-02-02 18:17   ` Rick Jones
2007-02-02 19:21 ` Andi Kleen
2007-02-02 18:46   ` Rick Jones
2007-02-02 19:06     ` Andi Kleen
2007-02-02 19:54       ` Rick Jones
2007-02-02 20:20         ` Andi Kleen [this message]
2007-02-02 20:41           ` Rick Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200702022120.52055.ak@suse.de \
    --to=ak@suse.de \
    --cc=netdev@vger.kernel.org \
    --cc=rick.jones2@hp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).