* [PATCH 2/3] d80211-bcm43xx: Add control structure for beacontemplates
@ 2007-02-03 16:25 Ivo van Doorn
2007-02-03 16:47 ` Michael Buesch
0 siblings, 1 reply; 2+ messages in thread
From: Ivo van Doorn @ 2007-02-03 16:25 UTC (permalink / raw)
To: Jiri Benc, John Linville, Michael Buesch, Michael Wu; +Cc: netdev
Drivers that require beacon templates will also have the
control structure at their disposal and should always free it.
bcm43xx doesn't use the control structure, but should still free it.
Signed-off-by Ivo van Doorn <IvDoorn@gmail.com>
---
diff --git a/drivers/net/wireless/d80211/bcm43xx/bcm43xx_main.c b/drivers/net/wireless/d80211/bcm43xx/bcm43xx_main.c
index 9f4d51d..24be8f5 100644
--- a/drivers/net/wireless/d80211/bcm43xx/bcm43xx_main.c
+++ b/drivers/net/wireless/d80211/bcm43xx/bcm43xx_main.c
@@ -2732,8 +2732,10 @@ static int bcm43xx_config_interface(struct ieee80211_hw *hw,
if (bcm43xx_is_mode(wl, IEEE80211_IF_TYPE_AP)) {
assert(conf->type == IEEE80211_IF_TYPE_AP);
bcm43xx_set_ssid(dev, conf->ssid, conf->ssid_len);
- if (conf->beacon)
+ if (conf->beacon) {
bcm43xx_refresh_templates(dev, conf->beacon);
+ kfree(conf->beacon_control);
+ }
}
}
spin_unlock_irqrestore(&wl->irq_lock, flags);
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH 2/3] d80211-bcm43xx: Add control structure for beacontemplates
2007-02-03 16:25 [PATCH 2/3] d80211-bcm43xx: Add control structure for beacontemplates Ivo van Doorn
@ 2007-02-03 16:47 ` Michael Buesch
0 siblings, 0 replies; 2+ messages in thread
From: Michael Buesch @ 2007-02-03 16:47 UTC (permalink / raw)
To: Ivo van Doorn; +Cc: Jiri Benc, John Linville, Michael Wu, netdev
On Saturday 03 February 2007 17:25, Ivo van Doorn wrote:
> Drivers that require beacon templates will also have the
> control structure at their disposal and should always free it.
>
> bcm43xx doesn't use the control structure, but should still free it.
>
> Signed-off-by Ivo van Doorn <IvDoorn@gmail.com>
>
> ---
>
> diff --git a/drivers/net/wireless/d80211/bcm43xx/bcm43xx_main.c b/drivers/net/wireless/d80211/bcm43xx/bcm43xx_main.c
> index 9f4d51d..24be8f5 100644
> --- a/drivers/net/wireless/d80211/bcm43xx/bcm43xx_main.c
> +++ b/drivers/net/wireless/d80211/bcm43xx/bcm43xx_main.c
> @@ -2732,8 +2732,10 @@ static int bcm43xx_config_interface(struct ieee80211_hw *hw,
> if (bcm43xx_is_mode(wl, IEEE80211_IF_TYPE_AP)) {
> assert(conf->type == IEEE80211_IF_TYPE_AP);
> bcm43xx_set_ssid(dev, conf->ssid, conf->ssid_len);
> - if (conf->beacon)
> + if (conf->beacon) {
> bcm43xx_refresh_templates(dev, conf->beacon);
> + kfree(conf->beacon_control);
> + }
> }
> }
ACK to this patch, for now.
I will take care to actually properly set the beacon tx control
parameters in hardware (the possible ones) with a later patch.
--
Greetings Michael.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-02-03 16:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-02-03 16:25 [PATCH 2/3] d80211-bcm43xx: Add control structure for beacontemplates Ivo van Doorn
2007-02-03 16:47 ` Michael Buesch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).