From: Ivo van Doorn <ivdoorn@gmail.com>
To: Jiri Benc <jbenc@suse.cz>,
"John Linville" <linville@tuxdriver.com>,
Michael Buesch <mb@bu3sch.de>,
Michael Wu <flamingice@sourmilk.net>,
netdev@vger.kernel.org
Subject: [PATCH 3/3] d80211-p54: Add control structure for beacontemplates
Date: Sat, 3 Feb 2007 17:25:22 +0100 [thread overview]
Message-ID: <200702031725.22885.IvDoorn@gmail.com> (raw)
Drivers that require beacon templates will also have the
control structure at their disposal and should always free it.
p54 seems to ignore the beacon that is being passed,
even though it is requesting the BEACON_TEMPLATE.
That is why I not only added a line to free the control structure
but also the beacon itself.
Signed-off-by Ivo van Doorn <IvDoorn@gmail.com>
---
diff --git a/drivers/net/wireless/d80211/p54/prism54common.c b/drivers/net/wireless/d80211/p54/prism54common.c
index fd4ea5d..5a00d65 100644
--- a/drivers/net/wireless/d80211/p54/prism54common.c
+++ b/drivers/net/wireless/d80211/p54/prism54common.c
@@ -714,6 +714,8 @@ static int p54_config_interface(struct ieee80211_hw *dev, int if_id,
p54_set_filter(dev, 0, dev->perm_addr, conf->bssid, 0, 1, 0, 0xF642);
p54_set_filter(dev, 0, dev->perm_addr, conf->bssid, 2, 0, 0, 0);
p54_set_leds(dev, 1, !is_multicast_ether_addr(conf->bssid), 0);
+ dev_kfree_skb(conf->beacon);
+ kfree(conf->beacon_control);
return 0;
}
next reply other threads:[~2007-02-03 16:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-03 16:25 Ivo van Doorn [this message]
2007-02-03 16:33 ` [PATCH 3/3] d80211-p54: Add control structure for beacontemplates Michael Wu
2007-02-03 16:40 ` Ivo van Doorn
2007-02-03 16:49 ` Michael Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200702031725.22885.IvDoorn@gmail.com \
--to=ivdoorn@gmail.com \
--cc=flamingice@sourmilk.net \
--cc=jbenc@suse.cz \
--cc=linville@tuxdriver.com \
--cc=mb@bu3sch.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).