From: David Miller <davem@davemloft.net>
To: baruch@ev-en.org
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 2/3] Seperate DSACK from SACK fast path
Date: Sun, 04 Feb 2007 23:36:58 -0800 (PST) [thread overview]
Message-ID: <20070204.233658.130236812.davem@davemloft.net> (raw)
In-Reply-To: <20070202144121.26863.90947.sendpatchset@galon.ev-en.org>
From: Baruch Even <baruch@ev-en.org>
Date: Fri, 02 Feb 2007 16:41:21 +0200
> Move DSACK code outside the SACK fast-path checking code. If the DSACK
> determined that the information was too old we stayed with a partial cache
> copied. Most likely this matters very little since the next packet will not be
> DSACK and we will find it in the cache. but it's still not good form and there
> is little reason to couple the two checks.
>
> Since the SACK receive cache doesn't need the data to be in host order we also
> remove the ntohl in the checking loop.
>
> Signed-Off-By: Baruch Even <baruch@ev-en.org>
Thanks for fixing up the endianness annotations, applied.
next prev parent reply other threads:[~2007-02-05 7:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20070202144116.26863.3722.sendpatchset@galon.ev-en.org>
2007-02-05 7:36 ` [PATCH 1/3] Advance fast path pointer for first block only David Miller
[not found] ` <20070202144121.26863.90947.sendpatchset@galon.ev-en.org>
2007-02-05 7:36 ` David Miller [this message]
[not found] ` <20070202144127.26863.97696.sendpatchset@galon.ev-en.org>
2007-02-05 7:38 ` [PATCH 3/3] Check num sacks in SACK fast path David Miller
[not found] <20070129071339.24050.21052.sendpatchset@galon.ev-en.org>
[not found] ` <20070129071344.24050.14971.sendpatchset@galon.ev-en.org>
2007-01-31 20:49 ` [PATCH 2/3] Seperate DSACK from " David Miller
2007-01-27 16:47 [PATCH 0/3] Fix issues with SACK processing Baruch Even
2007-01-27 16:49 ` [PATCH 2/3] Seperate DSACK from SACK fast path Baruch Even
2007-01-28 4:06 ` David Miller
2007-01-28 5:27 ` Baruch Even
2007-01-29 5:06 ` Herbert Xu
2007-01-29 5:28 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070204.233658.130236812.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=baruch@ev-en.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).