From: Ingo Oeser <netdev@axxeo.de>
To: Stephen Hemminger <shemminger@linux-foundation.org>
Cc: Jeff Garzik <jgarzik@pobox.com>, netdev@vger.kernel.org
Subject: Re: [PATCH 3/4] skge: WOL support
Date: Mon, 5 Feb 2007 14:25:41 +0100 [thread overview]
Message-ID: <200702051425.41954.netdev@axxeo.de> (raw)
In-Reply-To: <20070202162419.257951000@linux-foundation.org>
Hi Stephen,
just a nitpick.
Stephen Hemminger schrieb:
> --- skge.orig/drivers/net/skge.c
> +++ skge/drivers/net/skge.c
> @@ -132,18 +132,93 @@ static void skge_get_regs(struct net_dev
> }
>
> /* Wake on Lan only supported on Yukon chips with rev 1 or above */
> -static int wol_supported(const struct skge_hw *hw)
> +static u32 wol_supported(const struct skge_hw *hw)
> {
> - return !((hw->chip_id == CHIP_ID_GENESIS ||
> - (hw->chip_id == CHIP_ID_YUKON && hw->chip_rev == 0)));
> + if (hw->chip_id == CHIP_ID_YUKON && hw->chip_rev != 0)
> + return WAKE_MAGIC | WAKE_PHY;
> + else
> + return 0;
> +}
You can delete that comment, if you write exactly, what the comment says:
if (hw->chip_id == CHIP_ID_YUKON && hw->chip_rev >= 1)
return WAKE_MAGIC | WAKE_PHY;
else
return 0;
Regards
Ingo Oeser
next prev parent reply other threads:[~2007-02-05 13:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-02 16:22 [PATCH 0/4] skge: update Stephen Hemminger
2007-02-02 16:22 ` [PATCH 1/4] skge: handle zero address at open Stephen Hemminger
2007-02-07 0:08 ` Jeff Garzik
2007-02-02 16:22 ` [PATCH 2/4] skge: use dev_printk Stephen Hemminger
2007-02-02 16:22 ` [PATCH 3/4] skge: WOL support Stephen Hemminger
2007-02-05 13:25 ` Ingo Oeser [this message]
2007-02-02 16:22 ` [PATCH 4/4] skge: version 1.10 Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200702051425.41954.netdev@axxeo.de \
--to=netdev@axxeo.de \
--cc=jgarzik@pobox.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).