From: Arnd Bergmann <arnd@arndb.de>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: Marcelo Tosatti <marcelo@kvack.org>,
netdev <netdev@vger.kernel.org>, Jeff Garzik <jgarzik@pobox.com>,
"John W. Linville" <linville@redhat.com>,
Dan Williams <dcbw@redhat.com>,
"Luis R. Rodriguez" <mcgrof@gmail.com>,
Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Subject: Re: [PATCH] Marvell Libertas 8388 802.11b/g USB driver (v2)
Date: Mon, 5 Feb 2007 16:12:05 +0100 [thread overview]
Message-ID: <200702051612.06492.arnd@arndb.de> (raw)
In-Reply-To: <20070205140147.GA17286@tuxdriver.com>
On Monday 05 February 2007 15:01, John W. Linville wrote:
>
> > I disagree, entry/exit points have been shown to be useful in practice
> > to identify firmware problems on field.
>
> I'm not too fond of the ENTER/LEAVE stuff either. But, I do sympathize
> that they _can_ be useful in certain circumstances/workflows/whatever.
>
> Is there an official "party line" on this documented somewhere
> (i.e. CodingStyle or elsewhere)? A quick search doesn't reveal one
> to me.
I don't think there is a formal rule. My personal opinion is that
you should trace events that come from the hardware of from the user,
if you trace at all, but never trace function call sequences that
can be simply identified by knowing the source code.
Arnd <><
next prev parent reply other threads:[~2007-02-05 15:12 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-16 18:55 [PATCH] Marvell Libertas 8388 802.11b/g USB driver (v2) Marcelo Tosatti
2007-01-16 19:32 ` Arkadiusz Miskiewicz
2007-01-16 22:41 ` Dan Williams
2007-01-17 7:52 ` Johannes Berg
2007-01-17 18:42 ` Marcelo Tosatti
2007-01-17 23:06 ` Christoph Hellwig
2007-01-18 15:41 ` Dan Williams
2007-01-18 22:40 ` Christoph Hellwig
2007-01-18 22:54 ` Jon Smirl
2007-01-19 3:29 ` Dan Williams
2007-01-19 3:27 ` Dan Williams
2007-01-17 13:11 ` Jiri Benc
2007-01-17 15:01 ` Dan Williams
2007-01-17 15:18 ` Johannes Berg
2007-01-17 17:43 ` Dan Williams
2007-01-17 18:00 ` Dan Williams
2007-01-17 23:09 ` Christoph Hellwig
2007-01-17 23:19 ` Jeff Garzik
2007-01-18 8:22 ` John W. Linville
2007-01-24 15:26 ` Marcelo Tosatti
2007-01-24 18:52 ` Dan Williams
2007-01-24 20:13 ` John W. Linville
2007-01-18 15:40 ` Dan Williams
2007-01-17 18:01 ` Johannes Berg
2007-01-22 11:26 ` Marcelo Tosatti
2007-01-22 15:20 ` Jon Smirl
2007-01-23 15:41 ` Johannes Berg
2007-01-23 16:18 ` Jon Smirl
2007-01-23 16:54 ` Johannes Berg
2007-01-23 17:14 ` Jon Smirl
2007-01-23 17:38 ` Johannes Berg
2007-01-23 17:59 ` Dan Williams
2007-01-23 18:23 ` Jon Smirl
2007-01-23 18:30 ` Johannes Berg
2007-01-23 19:01 ` Jon Smirl
2007-01-23 19:13 ` Johannes Berg
2007-01-22 11:28 ` Marcelo Tosatti
2007-01-17 18:07 ` Jiri Benc
2007-01-18 15:43 ` Marcelo Tosatti
2007-01-17 15:43 ` Jiri Benc
2007-01-18 15:02 ` Marcelo Tosatti
2007-01-27 1:53 ` Arnd Bergmann
2007-02-03 22:43 ` Marcelo Tosatti
2007-02-05 14:01 ` John W. Linville
2007-02-05 15:12 ` Arnd Bergmann [this message]
2007-02-05 15:42 ` Christoph Hellwig
2007-02-06 22:42 ` Marcelo Tosatti
2007-02-10 14:05 ` Marcelo Tosatti
-- strict thread matches above, loose matches on Subject: below --
2007-01-20 20:15 Marcelo Tosatti
2007-01-20 20:15 Marcelo Tosatti
2007-02-01 0:58 ` Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200702051612.06492.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=acme@ghostprotocols.net \
--cc=dcbw@redhat.com \
--cc=jgarzik@pobox.com \
--cc=linville@redhat.com \
--cc=linville@tuxdriver.com \
--cc=marcelo@kvack.org \
--cc=mcgrof@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).