From: Andrew Morton <akpm@linux-foundation.org>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, kaber@trash.net,
Dipankar Sarma <dipankar@in.ibm.com>,
"Paul E. McKenney" <paulmck@us.ibm.com>,
Ingo Molnar <mingo@elte.hu>
Subject: Re: [patch 11/11] netfilter warning fix
Date: Mon, 5 Feb 2007 18:18:10 -0800 [thread overview]
Message-ID: <20070205181810.bbfbf42c.akpm@linux-foundation.org> (raw)
In-Reply-To: <20070205.181026.122835715.davem@davemloft.net>
On Mon, 05 Feb 2007 18:10:26 -0800 (PST) David Miller <davem@davemloft.net> wrote:
> From: akpm@linux-foundation.org
> Date: Mon, 05 Feb 2007 16:31:11 -0800
>
> > From: Andrew Morton <akpm@osdl.org>
> >
> > "using smp_processor_id() in preemptible code"
> >
> > Cc: Patrick McHardy <kaber@trash.net>
> > Cc: "David S. Miller" <davem@davemloft.net>
> > Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
>
> We NAK'd this because every patch in the lockdep trace should
> have preemption disabled because software interrupts ought
> to be disabled in those code paths.
>
> Someone needs to track down why this is really happening.
I think the finger was pointed at preemptible rcu, in -mm. iirc, the net
stats code is assuming that rcu_read_lock() disables preemption as a side-effect,
which rcu-preempt makes no-longer-true.
Not sure what to do there. Perhaps add a new
rcu_read_lock_with_preempt_disable() thing which will dtrt with either
config.
next prev parent reply other threads:[~2007-02-06 2:18 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-06 0:31 [patch 11/11] netfilter warning fix akpm
2007-02-06 2:10 ` David Miller
2007-02-06 2:18 ` Andrew Morton [this message]
2007-02-06 2:44 ` David Miller
2007-02-06 2:53 ` Andrew Morton
2007-02-06 12:34 ` Ingo Molnar
2007-02-06 19:43 ` David Miller
2007-02-06 21:02 ` Ingo Molnar
2007-02-06 21:23 ` David Miller
2007-02-06 21:58 ` Ingo Molnar
2007-02-07 6:43 ` Patrick McHardy
2007-02-07 8:07 ` Ingo Molnar
2007-02-07 8:13 ` David Miller
2007-02-07 8:16 ` Patrick McHardy
2007-02-07 8:18 ` Ingo Molnar
2007-02-06 9:21 ` Martin Josefsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070205181810.bbfbf42c.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=dipankar@in.ibm.com \
--cc=kaber@trash.net \
--cc=mingo@elte.hu \
--cc=netdev@vger.kernel.org \
--cc=paulmck@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).