From: Stephen Hemminger <shemminger@linux-foundation.org>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: netdev@vger.kernel.org
Subject: [PATCH 3/7] sky2: TSO support for EC_U
Date: Tue, 06 Feb 2007 10:45:41 -0800 [thread overview]
Message-ID: <20070206184855.063544000@linux-foundation.org> (raw)
In-Reply-To: 20070206184538.675048000@linux-foundation.org
[-- Attachment #1: sky2-ec-u-tso.patch --]
[-- Type: text/plain, Size: 1170 bytes --]
The Yukon EC_U chipset apparently supports TSO but only for non-Jumbo
frame sizes because it lacks a Ram buffer.
Signed-off-by: Stephen Hemminger <shemminger@linux-foundation.org>
---
drivers/net/sky2.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
--- sky2-dev.orig/drivers/net/sky2.c 2007-02-06 10:44:19.000000000 -0800
+++ sky2-dev/drivers/net/sky2.c 2007-02-06 10:44:21.000000000 -0800
@@ -1895,8 +1895,9 @@
if (new_mtu < ETH_ZLEN || new_mtu > ETH_JUMBO_MTU)
return -EINVAL;
+ /* TSO on Yukon Ultra and MTU > 1500 not supported */
if (hw->chip_id == CHIP_ID_YUKON_EC_U && new_mtu > ETH_DATA_LEN)
- return -EINVAL;
+ dev->features &= ~NETIF_F_TSO;
if (!netif_running(dev)) {
dev->mtu = new_mtu;
@@ -3350,11 +3351,9 @@
sky2->port = port;
- if (hw->chip_id != CHIP_ID_YUKON_EC_U)
- dev->features |= NETIF_F_TSO;
+ dev->features |= NETIF_F_TSO | NETIF_F_IP_CSUM | NETIF_F_SG;
if (highmem)
dev->features |= NETIF_F_HIGHDMA;
- dev->features |= NETIF_F_IP_CSUM | NETIF_F_SG;
#ifdef SKY2_VLAN_TAG_USED
dev->features |= NETIF_F_HW_VLAN_TX | NETIF_F_HW_VLAN_RX;
--
Stephen Hemminger <shemminger@linux-foundation.org>
next prev parent reply other threads:[~2007-02-06 18:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-06 18:45 [PATCH 0/7] sky2 v1.12 patches Stephen Hemminger
2007-02-06 18:45 ` [PATCH 1/7] sky2: add Wake On Lan support Stephen Hemminger
2007-02-07 0:20 ` Jeff Garzik
2007-02-06 18:45 ` [PATCH 2/7] sky2: use dev_err for error reports Stephen Hemminger
2007-02-06 18:45 ` Stephen Hemminger [this message]
2007-02-06 18:45 ` [PATCH 4/7] sky2: safer transmit timeout Stephen Hemminger
2007-02-06 18:45 ` [PATCH 5/7] sky2: Yukon Extreme support Stephen Hemminger
2007-02-06 21:52 ` Francois Romieu
2007-02-06 22:07 ` Stephen Hemminger
2007-02-06 18:45 ` [PATCH 6/7] sky2: add new chip ids Stephen Hemminger
2007-02-06 18:45 ` [PATCH 7/7] sky2: version 1.12 Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070206184855.063544000@linux-foundation.org \
--to=shemminger@linux-foundation.org \
--cc=jgarzik@pobox.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).