From: David Miller <davem@davemloft.net>
To: fubar@us.ibm.com
Cc: andy@greyhouse.net, akpm@linux-foundation.org,
netdev@vger.kernel.org, shemminger@linux-foundation.org,
lpiccilli@gelre.com.br, bugme-daemon@bugzilla.kernel.org
Subject: Re: [Bugme-new] [Bug 7974] New: BUG: scheduling while atomic: swapper/0x10000100/0
Date: Tue, 13 Feb 2007 14:32:43 -0800 (PST) [thread overview]
Message-ID: <20070213.143243.78711492.davem@davemloft.net> (raw)
In-Reply-To: <200702132226.l1DMQS22009230@death.nxdomain.ibm.com>
From: Jay Vosburgh <fubar@us.ibm.com>
Date: Tue, 13 Feb 2007 14:26:28 -0800
> In reference to Andy's recent patch (which first did conditional
> locking for rtnl, then later acquired rtnl for every entry into the
> timer function), I know the conditional locking isn't popular, but it
> seems to me that it's a less bad alternative than holding rtnl every
> time the bond_mii_monitor() runs (typically 10 - 50 times per second).
> Or is the rtnl lock really so cheap that this isn't an issue? The
> overwhelming majority of cases the mii_monitor won't need to do anything
> that requires rtnl, so only holding it when needed is better.
We definitely don't want to take the RTNL that often if it can
be avoided.
Maybe if you put the RTNL acquisition deeper into the call
path, ie. down into the code that knows RTNL is needed,
perhaps it won't be so ugly. Replace the conditions with
functions.
next prev parent reply other threads:[~2007-02-13 22:32 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200702091623.l19GNiUP006513@fire-2.osdl.org>
2007-02-09 21:38 ` [Bugme-new] [Bug 7974] New: BUG: scheduling while atomic: swapper/0x10000100/0 Andrew Morton
2007-02-09 22:35 ` Francois Romieu
2007-02-09 23:31 ` Michael Chan
2007-02-11 22:53 ` Herbert Xu
2007-02-13 20:29 ` Andy Gospodarek
2007-02-13 22:26 ` Jay Vosburgh
2007-02-13 22:32 ` David Miller [this message]
2007-02-13 23:08 ` Andy Gospodarek
2007-02-13 23:33 ` Jay Vosburgh
2007-02-13 23:54 ` Stephen Hemminger
2007-02-14 0:10 ` Andy Gospodarek
2007-02-14 1:31 ` Andy Gospodarek
2007-02-14 2:11 ` Jay Vosburgh
2007-02-15 21:00 ` Andy Gospodarek
2007-02-15 23:45 ` Jay Vosburgh
2007-02-19 21:21 ` Andy Gospodarek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070213.143243.78711492.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@linux-foundation.org \
--cc=andy@greyhouse.net \
--cc=bugme-daemon@bugzilla.kernel.org \
--cc=fubar@us.ibm.com \
--cc=lpiccilli@gelre.com.br \
--cc=netdev@vger.kernel.org \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).