From: Stephen Hemminger <shemminger@linux-foundation.org>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: netdev@vger.kernel.org, sk-drivers@lists.linux-foundation.org
Subject: [PATCH 2/6] sky2: no need to reset pause bits on shutdown
Date: Thu, 15 Feb 2007 16:40:31 -0800 [thread overview]
Message-ID: <20070216004141.831209000@linux-foundation.org> (raw)
In-Reply-To: 20070216004028.943889000@linux-foundation.org
[-- Attachment #1: sky2-no-asym-down.patch --]
[-- Type: text/plain, Size: 801 bytes --]
Resetting the pause bits on shutdown is not necessary.
The code was inherited from the vendor driver, and it is currently #ifdef'd
out there as well.
Signed-off-by: Stephen Hemminger <shemminger@linux-foundation.org>
--- sky2-dev.orig/drivers/net/sky2.c 2007-02-13 15:08:31.000000000 -0800
+++ sky2-dev/drivers/net/sky2.c 2007-02-13 15:13:03.000000000 -0800
@@ -1742,13 +1742,6 @@
reg &= ~(GM_GPCR_RX_ENA | GM_GPCR_TX_ENA);
gma_write16(hw, port, GM_GP_CTRL, reg);
- if (sky2->flow_status == FC_RX) {
- /* restore Asymmetric Pause bit */
- gm_phy_write(hw, port, PHY_MARV_AUNE_ADV,
- gm_phy_read(hw, port, PHY_MARV_AUNE_ADV)
- | PHY_M_AN_ASP);
- }
-
netif_carrier_off(sky2->netdev);
netif_stop_queue(sky2->netdev);
--
Stephen Hemminger <shemminger@linux-foundation.org>
next prev parent reply other threads:[~2007-02-16 0:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-16 0:40 [PATCH 0/6] sky2: v1.13 patches Stephen Hemminger
2007-02-16 0:40 ` [PATCH 1/6] sky2: dont flush good pause frames Stephen Hemminger
2007-02-17 20:32 ` Jeff Garzik
2007-02-16 0:40 ` Stephen Hemminger [this message]
2007-02-16 0:40 ` [PATCH 3/6] sky2: flow control negotiation for Yukon-FE Stephen Hemminger
2007-02-16 0:40 ` [PATCH 4/6] sky2: transmit timeout Stephen Hemminger
2007-02-16 0:40 ` [PATCH 5/6] sky2: receive error handling improvements Stephen Hemminger
2007-02-16 0:40 ` [PATCH 6/6] sky2: v1.13 Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070216004141.831209000@linux-foundation.org \
--to=shemminger@linux-foundation.org \
--cc=jgarzik@pobox.com \
--cc=netdev@vger.kernel.org \
--cc=sk-drivers@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).