From: Ben Dooks <ben@fluff.org.uk>
To: netdev@vger.kernel.org
Cc: rmk@arm.linux.org.uk
Subject: Re: [PATCH] dm9000: do not kfree() netdevice
Date: Fri, 16 Feb 2007 09:56:47 +0000 [thread overview]
Message-ID: <20070216095647.GA24236@fluff.org.uk> (raw)
In-Reply-To: <20070212120539.GA31390@fluff.org.uk>
On Mon, Feb 12, 2007 at 12:05:39PM +0000, Ben Dooks wrote:
> The DM9000 network driver is calling kfree() on an netdev
> causing the system to oops if the probe fails. The right
> thing to do is call free_netdev().
>
> Thanks to Russell King for spotting this.
>
> Signed-off-by: Ben Dooks <ben-linux@fluff.org>
>
> diff -urpN -X ../dontdiff linux-2.6.20/drivers/net/dm9000.c linux-2.6.20-dmfix/drivers/net/dm9000.c
> --- linux-2.6.20/drivers/net/dm9000.c 2007-02-04 18:44:54.000000000 +0000
> +++ linux-2.6.20-dmfix/drivers/net/dm9000.c 2007-02-12 12:01:22.000000000 +0000
> @@ -601,7 +601,7 @@ dm9000_probe(struct platform_device *pde
> printk("%s: not found (%d).\n", CARDNAME, ret);
>
> dm9000_release_board(pdev, db);
> - kfree(ndev);
> + free_netdev(ndev);
>
> return ret;
> }
> @@ -1194,7 +1194,7 @@ dm9000_drv_remove(struct platform_device
>
> unregister_netdev(ndev);
> dm9000_release_board(pdev, (board_info_t *) ndev->priv);
> - kfree(ndev); /* free device structure */
> + free_netdev(ndev); /* free device structure */
>
> PRINTK1("clean_module() exit\n");
Do I need to send this patch to a particual person
to ensure that it gets included into the kernel?
--
Ben (ben@fluff.org, http://www.fluff.org/)
'a smiley only costs 4 bytes'
prev parent reply other threads:[~2007-02-16 9:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-12 12:05 [PATCH] dm9000: do not kfree() netdevice Ben Dooks
2007-02-16 9:56 ` Ben Dooks [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070216095647.GA24236@fluff.org.uk \
--to=ben@fluff.org.uk \
--cc=netdev@vger.kernel.org \
--cc=rmk@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).