* [PATCH] dm9000: do not kfree() netdevice
@ 2007-02-12 12:05 Ben Dooks
2007-02-16 9:56 ` Ben Dooks
0 siblings, 1 reply; 2+ messages in thread
From: Ben Dooks @ 2007-02-12 12:05 UTC (permalink / raw)
To: netdev; +Cc: rmk
The DM9000 network driver is calling kfree() on an netdev
causing the system to oops if the probe fails. The right
thing to do is call free_netdev().
Thanks to Russell King for spotting this.
Signed-off-by: Ben Dooks <ben-linux@fluff.org>
diff -urpN -X ../dontdiff linux-2.6.20/drivers/net/dm9000.c linux-2.6.20-dmfix/drivers/net/dm9000.c
--- linux-2.6.20/drivers/net/dm9000.c 2007-02-04 18:44:54.000000000 +0000
+++ linux-2.6.20-dmfix/drivers/net/dm9000.c 2007-02-12 12:01:22.000000000 +0000
@@ -601,7 +601,7 @@ dm9000_probe(struct platform_device *pde
printk("%s: not found (%d).\n", CARDNAME, ret);
dm9000_release_board(pdev, db);
- kfree(ndev);
+ free_netdev(ndev);
return ret;
}
@@ -1194,7 +1194,7 @@ dm9000_drv_remove(struct platform_device
unregister_netdev(ndev);
dm9000_release_board(pdev, (board_info_t *) ndev->priv);
- kfree(ndev); /* free device structure */
+ free_netdev(ndev); /* free device structure */
PRINTK1("clean_module() exit\n");
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] dm9000: do not kfree() netdevice
2007-02-12 12:05 [PATCH] dm9000: do not kfree() netdevice Ben Dooks
@ 2007-02-16 9:56 ` Ben Dooks
0 siblings, 0 replies; 2+ messages in thread
From: Ben Dooks @ 2007-02-16 9:56 UTC (permalink / raw)
To: netdev; +Cc: rmk
On Mon, Feb 12, 2007 at 12:05:39PM +0000, Ben Dooks wrote:
> The DM9000 network driver is calling kfree() on an netdev
> causing the system to oops if the probe fails. The right
> thing to do is call free_netdev().
>
> Thanks to Russell King for spotting this.
>
> Signed-off-by: Ben Dooks <ben-linux@fluff.org>
>
> diff -urpN -X ../dontdiff linux-2.6.20/drivers/net/dm9000.c linux-2.6.20-dmfix/drivers/net/dm9000.c
> --- linux-2.6.20/drivers/net/dm9000.c 2007-02-04 18:44:54.000000000 +0000
> +++ linux-2.6.20-dmfix/drivers/net/dm9000.c 2007-02-12 12:01:22.000000000 +0000
> @@ -601,7 +601,7 @@ dm9000_probe(struct platform_device *pde
> printk("%s: not found (%d).\n", CARDNAME, ret);
>
> dm9000_release_board(pdev, db);
> - kfree(ndev);
> + free_netdev(ndev);
>
> return ret;
> }
> @@ -1194,7 +1194,7 @@ dm9000_drv_remove(struct platform_device
>
> unregister_netdev(ndev);
> dm9000_release_board(pdev, (board_info_t *) ndev->priv);
> - kfree(ndev); /* free device structure */
> + free_netdev(ndev); /* free device structure */
>
> PRINTK1("clean_module() exit\n");
Do I need to send this patch to a particual person
to ensure that it gets included into the kernel?
--
Ben (ben@fluff.org, http://www.fluff.org/)
'a smiley only costs 4 bytes'
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-02-16 9:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-02-12 12:05 [PATCH] dm9000: do not kfree() netdevice Ben Dooks
2007-02-16 9:56 ` Ben Dooks
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).