2.6.19-rc6-mm1: no help text for TCP_MD5SIG_DEBUG

2.6.19-rc6-mm1: no help text for TCP_MD5SIG_DEBUG

[Adrian Bunk]

On Thu, Nov 23, 2006 at 02:17:03AM -0800, Andrew Morton wrote:
>...
> Changes since 2.6.19-rc5-mm2:
>...
>  git-net.patch
>...
>  git trees
>...

TCP_MD5SIG_DEBUG lacks a help text.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

Re: 2.6.19-rc6-mm1: no help text for TCP_MD5SIG_DEBUG

[David Miller]

From: Adrian Bunk <bunk@stusta.de>
Date: Fri, 24 Nov 2006 00:30:30 +0100

> On Thu, Nov 23, 2006 at 02:17:03AM -0800, Andrew Morton wrote:
> >...
> > Changes since 2.6.19-rc5-mm2:
> >...
> >  git-net.patch
> >...
> >  git trees
> >...
> 
> TCP_MD5SIG_DEBUG lacks a help text.

Thanks for the report Adrian, I'll take care of this.

2.6.19-rc6-mm1: drivers/net/chelsio/: unused code

[Adrian Bunk]

On Thu, Nov 23, 2006 at 02:17:03AM -0800, Andrew Morton wrote:
>...
> Changes since 2.6.19-rc5-mm2:
>...
> +chelsio-22-driver.patch
>...
>  netdev updates

It is suspicious that the following newly added code is completely unused:
  drivers/net/chelsio/ixf1010.o
    t1_ixf1010_ops
  drivers/net/chelsio/mac.o
    t1_chelsio_mac_ops
  drivers/net/chelsio/vsc8244.o
    t1_vsc8244_ops

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

Re: 2.6.19-rc6-mm1: drivers/net/chelsio/: unused code

[Stephen Hemminger]

On Fri, 24 Nov 2006 01:17:31 +0100
Adrian Bunk <bunk@stusta.de> wrote:

> On Thu, Nov 23, 2006 at 02:17:03AM -0800, Andrew Morton wrote:
> >...
> > Changes since 2.6.19-rc5-mm2:
> >...
> > +chelsio-22-driver.patch
> >...
> >  netdev updates
> 
> It is suspicious that the following newly added code is completely unused:
>   drivers/net/chelsio/ixf1010.o
>     t1_ixf1010_ops
>   drivers/net/chelsio/mac.o
>     t1_chelsio_mac_ops
>   drivers/net/chelsio/vsc8244.o
>     t1_vsc8244_ops
> 
> cu
> Adrian
> 

All that is gone in later version. I reposted new patches
after -mm2 was done.

Re: 2.6.19-rc6-mm1: drivers/net/chelsio/: unused code

[Adrian Bunk]

On Mon, Nov 27, 2006 at 10:24:55AM -0800, Stephen Hemminger wrote:
> On Fri, 24 Nov 2006 01:17:31 +0100
> Adrian Bunk <bunk@stusta.de> wrote:
> 
> > On Thu, Nov 23, 2006 at 02:17:03AM -0800, Andrew Morton wrote:
> > >...
> > > Changes since 2.6.19-rc5-mm2:
> > >...
> > > +chelsio-22-driver.patch
> > >...
> > >  netdev updates
> > 
> > It is suspicious that the following newly added code is completely unused:
> >   drivers/net/chelsio/ixf1010.o
> >     t1_ixf1010_ops
> >   drivers/net/chelsio/mac.o
> >     t1_chelsio_mac_ops
> >   drivers/net/chelsio/vsc8244.o
> >     t1_vsc8244_ops
> > 
> > cu
> > Adrian
> > 
> 
> All that is gone in later version. I reposted new patches
> after -mm2 was done.

It seems these patches didn't make it into 2.6.19-rc6-mm2 ?

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

Re: 2.6.19-rc6-mm1: drivers/net/chelsio/: unused code

[Andrew Morton]

On Wed, 29 Nov 2006 08:36:09 +0100
Adrian Bunk <bunk@stusta.de> wrote:

> On Mon, Nov 27, 2006 at 10:24:55AM -0800, Stephen Hemminger wrote:
> > On Fri, 24 Nov 2006 01:17:31 +0100
> > Adrian Bunk <bunk@stusta.de> wrote:
> > 
> > > On Thu, Nov 23, 2006 at 02:17:03AM -0800, Andrew Morton wrote:
> > > >...
> > > > Changes since 2.6.19-rc5-mm2:
> > > >...
> > > > +chelsio-22-driver.patch
> > > >...
> > > >  netdev updates
> > > 
> > > It is suspicious that the following newly added code is completely unused:
> > >   drivers/net/chelsio/ixf1010.o
> > >     t1_ixf1010_ops
> > >   drivers/net/chelsio/mac.o
> > >     t1_chelsio_mac_ops
> > >   drivers/net/chelsio/vsc8244.o
> > >     t1_vsc8244_ops
> > > 
> > > cu
> > > Adrian
> > > 
> > 
> > All that is gone in later version. I reposted new patches
> > after -mm2 was done.
> 
> It seems these patches didn't make it into 2.6.19-rc6-mm2 ?
> 

I dropped that patch and picked up Francois's tree instead.

Re: 2.6.19-rc6-mm1: drivers/net/chelsio/: unused code

[Adrian Bunk]

On Tue, Nov 28, 2006 at 11:47:19PM -0800, Andrew Morton wrote:
> On Wed, 29 Nov 2006 08:36:09 +0100
> Adrian Bunk <bunk@stusta.de> wrote:
> 
> > On Mon, Nov 27, 2006 at 10:24:55AM -0800, Stephen Hemminger wrote:
> > > On Fri, 24 Nov 2006 01:17:31 +0100
> > > Adrian Bunk <bunk@stusta.de> wrote:
> > > 
> > > > On Thu, Nov 23, 2006 at 02:17:03AM -0800, Andrew Morton wrote:
> > > > >...
> > > > > Changes since 2.6.19-rc5-mm2:
> > > > >...
> > > > > +chelsio-22-driver.patch
> > > > >...
> > > > >  netdev updates
> > > > 
> > > > It is suspicious that the following newly added code is completely unused:
> > > >   drivers/net/chelsio/ixf1010.o
> > > >     t1_ixf1010_ops
> > > >   drivers/net/chelsio/mac.o
> > > >     t1_chelsio_mac_ops
> > > >   drivers/net/chelsio/vsc8244.o
> > > >     t1_vsc8244_ops
> > > > 
> > > > cu
> > > > Adrian
> > > > 
> > > 
> > > All that is gone in later version. I reposted new patches
> > > after -mm2 was done.
> > 
> > It seems these patches didn't make it into 2.6.19-rc6-mm2 ?
> 
> I dropped that patch and picked up Francois's tree instead.

These structs are still both present and unused as of 2.6.20-mm1.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

Re: 2.6.19-rc6-mm1: drivers/net/chelsio/: unused code

[Stephen Hemminger]

On Tue, 20 Feb 2007 01:02:14 +0100
Adrian Bunk <bunk@stusta.de> wrote:

> On Tue, Nov 28, 2006 at 11:47:19PM -0800, Andrew Morton wrote:
> > On Wed, 29 Nov 2006 08:36:09 +0100
> > Adrian Bunk <bunk@stusta.de> wrote:
> > 
> > > On Mon, Nov 27, 2006 at 10:24:55AM -0800, Stephen Hemminger wrote:
> > > > On Fri, 24 Nov 2006 01:17:31 +0100
> > > > Adrian Bunk <bunk@stusta.de> wrote:
> > > > 
> > > > > On Thu, Nov 23, 2006 at 02:17:03AM -0800, Andrew Morton wrote:
> > > > > >...
> > > > > > Changes since 2.6.19-rc5-mm2:
> > > > > >...
> > > > > > +chelsio-22-driver.patch
> > > > > >...
> > > > > >  netdev updates
> > > > > 
> > > > > It is suspicious that the following newly added code is completely unused:
> > > > >   drivers/net/chelsio/ixf1010.o
> > > > >     t1_ixf1010_ops
> > > > >   drivers/net/chelsio/mac.o
> > > > >     t1_chelsio_mac_ops
> > > > >   drivers/net/chelsio/vsc8244.o
> > > > >     t1_vsc8244_ops
> > > > > 
> > > > > cu
> > > > > Adrian
> > > > > 
> > > > 
> > > > All that is gone in later version. I reposted new patches
> > > > after -mm2 was done.
> > > 
> > > It seems these patches didn't make it into 2.6.19-rc6-mm2 ?
> > 
> > I dropped that patch and picked up Francois's tree instead.
> 
> These structs are still both present and unused as of 2.6.20-mm1.

Please use your eyes, not your tool. Those functions are called in 2.6.20

static struct cmac *ixf1010_mac_create(adapter_t *adapter, int index)
{
...
	mac->ops = &ixf1010_ops;

static struct cmac *mac_create(adapter_t *adapter, int index)
{
...

	mac->ops = &chelsio_mac_ops;

mac_create gets called by 

int __devinit t1_init_sw_modules(adapter_t *adapter,
				 const struct board_info *bi)
{

	for_each_port(adapter, i) {
		u8 hw_addr[6];
		struct cmac *mac;
		int phy_addr = bi->mdio_phybaseaddr + i;

		adapter->port[i].phy = bi->gphy->create(adapter, phy_addr,
							bi->mdio_ops);

Re: 2.6.19-rc6-mm1: drivers/net/chelsio/: unused code

[Adrian Bunk]

On Tue, Feb 20, 2007 at 01:31:32PM -0800, Stephen Hemminger wrote:
> On Tue, 20 Feb 2007 01:02:14 +0100
> Adrian Bunk <bunk@stusta.de> wrote:
> 
> > On Tue, Nov 28, 2006 at 11:47:19PM -0800, Andrew Morton wrote:
> > > On Wed, 29 Nov 2006 08:36:09 +0100
> > > Adrian Bunk <bunk@stusta.de> wrote:
> > > 
> > > > On Mon, Nov 27, 2006 at 10:24:55AM -0800, Stephen Hemminger wrote:
> > > > > On Fri, 24 Nov 2006 01:17:31 +0100
> > > > > Adrian Bunk <bunk@stusta.de> wrote:
> > > > > 
> > > > > > On Thu, Nov 23, 2006 at 02:17:03AM -0800, Andrew Morton wrote:
> > > > > > >...
> > > > > > > Changes since 2.6.19-rc5-mm2:
> > > > > > >...
> > > > > > > +chelsio-22-driver.patch
> > > > > > >...
> > > > > > >  netdev updates
> > > > > > 
> > > > > > It is suspicious that the following newly added code is completely unused:
> > > > > >   drivers/net/chelsio/ixf1010.o
> > > > > >     t1_ixf1010_ops
> > > > > >   drivers/net/chelsio/mac.o
> > > > > >     t1_chelsio_mac_ops
> > > > > >   drivers/net/chelsio/vsc8244.o
> > > > > >     t1_vsc8244_ops
> > > > > > 
> > > > > > cu
> > > > > > Adrian
> > > > > > 
> > > > > 
> > > > > All that is gone in later version. I reposted new patches
> > > > > after -mm2 was done.
> > > > 
> > > > It seems these patches didn't make it into 2.6.19-rc6-mm2 ?
> > > 
> > > I dropped that patch and picked up Francois's tree instead.
> > 
> > These structs are still both present and unused as of 2.6.20-mm1.
> 
> Please use your eyes, not your tool. Those functions are called in 2.6.20


My eyes tell me:


> static struct cmac *ixf1010_mac_create(adapter_t *adapter, int index)
> {
> ...
> 	mac->ops = &ixf1010_ops;


ixf1010_ops != t1_ixf1010_ops


> static struct cmac *mac_create(adapter_t *adapter, int index)
> {
> ...
> 
> 	mac->ops = &chelsio_mac_ops;


chelsio_mac_ops != t1_chelsio_mac_ops


> mac_create gets called by 
> 
> int __devinit t1_init_sw_modules(adapter_t *adapter,
> 				 const struct board_info *bi)
> {
> 
> 	for_each_port(adapter, i) {
> 		u8 hw_addr[6];
> 		struct cmac *mac;
> 		int phy_addr = bi->mdio_phybaseaddr + i;
> 
> 		adapter->port[i].phy = bi->gphy->create(adapter, phy_addr,
> 							bi->mdio_ops);


No, since t1_chelsio_mac_ops isn't used anywhere and mac_create() isn't 
referenced except from t1_chelsio_mac_ops.


cu
Adrian

BTW: It's not my tool, the script behind "make namespacecheck" was
     written by Keith Owens.

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

[-mm patch] net/: possible cleanups

[Adrian Bunk]

On Thu, Nov 23, 2006 at 02:17:03AM -0800, Andrew Morton wrote:
>...
> Changes since 2.6.19-rc5-mm2:
>...
>  git-net.patch
>...
>  git trees
>...
 
This patch contains the following possible cleanups:
- make the following needlessly global functions statis:
  - ipv4/tcp.c: __tcp_alloc_md5sig_pool()
  - ipv4/tcp_ipv4.c: tcp_v4_reqsk_md5_lookup()
  - ipv4/udplite.c: udplite_rcv()
  - ipv4/udplite.c: udplite_err()
- make the following needlessly global structs static:
  - ipv4/tcp_ipv4.c: tcp_request_sock_ipv4_ops
  - ipv4/tcp_ipv4.c: tcp_sock_ipv4_specific
  - ipv6/tcp_ipv6.c: tcp_request_sock_ipv6_ops
- net/ipv{4,6}/udplite.c: remove inline's from static functions
                          (gcc should know best when to inline them)

Signed-off-by: Adrian Bunk <bunk@stusta.de>

---

 net/ipv4/tcp.c      |    2 +-
 net/ipv4/tcp_ipv4.c |    8 ++++----
 net/ipv4/udplite.c  |   10 +++++-----
 net/ipv6/tcp_ipv6.c |    2 +-
 net/ipv6/udplite.c  |   10 +++++-----
 5 files changed, 16 insertions(+), 16 deletions(-)

--- linux-2.6.19-rc6-mm1/net/ipv4/tcp.c.old	2006-11-24 01:30:11.000000000 +0100
+++ linux-2.6.19-rc6-mm1/net/ipv4/tcp.c	2006-11-24 01:31:21.000000000 +0100
@@ -2288,7 +2288,7 @@
 
 EXPORT_SYMBOL(tcp_free_md5sig_pool);
 
-struct tcp_md5sig_pool **__tcp_alloc_md5sig_pool(void)
+static struct tcp_md5sig_pool **__tcp_alloc_md5sig_pool(void)
 {
 	int cpu;
 	struct tcp_md5sig_pool **pool;
--- linux-2.6.19-rc6-mm1/net/ipv4/tcp_ipv4.c.old	2006-11-24 01:31:31.000000000 +0100
+++ linux-2.6.19-rc6-mm1/net/ipv4/tcp_ipv4.c	2006-11-24 01:33:00.000000000 +0100
@@ -841,8 +841,8 @@
 
 EXPORT_SYMBOL(tcp_v4_md5_lookup);
 
-struct tcp_md5sig_key *tcp_v4_reqsk_md5_lookup(struct sock *sk,
-					       struct request_sock *req)
+static struct tcp_md5sig_key *tcp_v4_reqsk_md5_lookup(struct sock *sk,
+						      struct request_sock *req)
 {
 	return tcp_v4_md5_do_lookup(sk, inet_rsk(req)->rmt_addr);
 }
@@ -1273,7 +1273,7 @@
 	.send_reset	=	tcp_v4_send_reset,
 };
 
-struct tcp_request_sock_ops tcp_request_sock_ipv4_ops = {
+static struct tcp_request_sock_ops tcp_request_sock_ipv4_ops = {
 #ifdef CONFIG_TCP_MD5SIG
 	.md5_lookup	=	tcp_v4_reqsk_md5_lookup,
 #endif
@@ -1861,7 +1861,7 @@
 #endif
 };
 
-struct tcp_sock_af_ops tcp_sock_ipv4_specific = {
+static struct tcp_sock_af_ops tcp_sock_ipv4_specific = {
 #ifdef CONFIG_TCP_MD5SIG
 	.md5_lookup		= tcp_v4_md5_lookup,
 	.calc_md5_hash		= tcp_v4_calc_md5_hash,
--- linux-2.6.19-rc6-mm1/net/ipv4/udplite.c.old	2006-11-24 01:33:19.000000000 +0100
+++ linux-2.6.19-rc6-mm1/net/ipv4/udplite.c	2006-11-24 01:34:07.000000000 +0100
@@ -18,23 +18,23 @@
 struct hlist_head 	udplite_hash[UDP_HTABLE_SIZE];
 static int		udplite_port_rover;
 
-__inline__ int udplite_get_port(struct sock *sk, unsigned short p,
-			int (*c)(const struct sock *, const struct sock *))
+int udplite_get_port(struct sock *sk, unsigned short p,
+		     int (*c)(const struct sock *, const struct sock *))
 {
 	return  __udp_lib_get_port(sk, p, udplite_hash, &udplite_port_rover, c);
 }
 
-static __inline__ int udplite_v4_get_port(struct sock *sk, unsigned short snum)
+static int udplite_v4_get_port(struct sock *sk, unsigned short snum)
 {
 	return udplite_get_port(sk, snum, ipv4_rcv_saddr_equal);
 }
 
-__inline__ int udplite_rcv(struct sk_buff *skb)
+static int udplite_rcv(struct sk_buff *skb)
 {
 	return __udp4_lib_rcv(skb, udplite_hash, 1);
 }
 
-__inline__ void udplite_err(struct sk_buff *skb, u32 info)
+static void udplite_err(struct sk_buff *skb, u32 info)
 {
 	return __udp4_lib_err(skb, info, udplite_hash);
 }
--- linux-2.6.19-rc6-mm1/net/ipv6/udplite.c.old	2006-11-24 01:34:21.000000000 +0100
+++ linux-2.6.19-rc6-mm1/net/ipv6/udplite.c	2006-11-24 01:51:24.000000000 +0100
@@ -17,14 +17,14 @@
 
 DEFINE_SNMP_STAT(struct udp_mib, udplite_stats_in6) __read_mostly;
 
-static __inline__ int udplitev6_rcv(struct sk_buff **pskb)
+static int udplitev6_rcv(struct sk_buff **pskb)
 {
 	return __udp6_lib_rcv(pskb, udplite_hash, 1);
 }
 
-static __inline__ void udplitev6_err(struct sk_buff *skb,
-				     struct inet6_skb_parm *opt,
-				     int type, int code, int offset, __be32 info)
+static void udplitev6_err(struct sk_buff *skb,
+			  struct inet6_skb_parm *opt,
+			  int type, int code, int offset, __be32 info)
 {
 	return __udp6_lib_err(skb, opt, type, code, offset, info, udplite_hash);
 }
@@ -35,7 +35,7 @@
 	.flags		=	INET6_PROTO_NOPOLICY|INET6_PROTO_FINAL,
 };
 
-static __inline__ int udplite_v6_get_port(struct sock *sk, unsigned short snum)
+static int udplite_v6_get_port(struct sock *sk, unsigned short snum)
 {
 	return udplite_get_port(sk, snum, ipv6_rcv_saddr_equal);
 }
--- linux-2.6.19-rc6-mm1/net/ipv6/tcp_ipv6.c.old	2006-11-24 01:35:02.000000000 +0100
+++ linux-2.6.19-rc6-mm1/net/ipv6/tcp_ipv6.c	2006-11-24 01:35:14.000000000 +0100
@@ -929,7 +929,7 @@
 	.send_reset	=	tcp_v6_send_reset
 };
 
-struct tcp_request_sock_ops tcp_request_sock_ipv6_ops = {
+static struct tcp_request_sock_ops tcp_request_sock_ipv6_ops = {
 #ifdef CONFIG_TCP_MD5SIG
 	.md5_lookup	=	tcp_v6_reqsk_md5_lookup,
 #endif

Re: [-mm patch] net/: possible cleanups

[David Miller]

From: Adrian Bunk <bunk@stusta.de>
Date: Fri, 24 Nov 2006 22:58:20 +0100

> This patch contains the following possible cleanups:
> - make the following needlessly global functions statis:
>   - ipv4/tcp.c: __tcp_alloc_md5sig_pool()
>   - ipv4/tcp_ipv4.c: tcp_v4_reqsk_md5_lookup()
>   - ipv4/udplite.c: udplite_rcv()
>   - ipv4/udplite.c: udplite_err()
> - make the following needlessly global structs static:
>   - ipv4/tcp_ipv4.c: tcp_request_sock_ipv4_ops
>   - ipv4/tcp_ipv4.c: tcp_sock_ipv4_specific
>   - ipv6/tcp_ipv6.c: tcp_request_sock_ipv6_ops
> - net/ipv{4,6}/udplite.c: remove inline's from static functions
>                           (gcc should know best when to inline them)
> 
> Signed-off-by: Adrian Bunk <bunk@stusta.de>

Applied, thanks Adrian.