From: David Miller <davem@davemloft.net>
To: dada1@cosmosbay.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH, take 2] TCP : keep copied_seq, rcv_wup and rcv_next together
Date: Thu, 22 Feb 2007 03:22:18 -0800 (PST) [thread overview]
Message-ID: <20070222.032218.59660260.davem@davemloft.net> (raw)
In-Reply-To: <200702221211.50289.dada1@cosmosbay.com>
From: Eric Dumazet <dada1@cosmosbay.com>
Date: Thu, 22 Feb 2007 12:11:50 +0100
> I noticed in oprofile study a cache miss in tcp_rcv_established() to read
> copied_seq.
...
> As you suggested, I changed tcp_create_openreq_child() so that these fields
> are changed together, to avoid adding a new store buffer stall.
>
> Patch is 64bit friendly (no new hole because of alignment constraints)
>
> Signed-off-by: Eric Dumazet <dada1@cosmosbay.com>
Looks great, applied to my tcp-2.6 GIT tree, thanks a lot!
next prev parent reply other threads:[~2007-02-22 11:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-15 23:46 [PATCH] Use random32() in net/ipv4/multipath Joe Perches
2007-02-22 9:26 ` David Miller
2007-02-22 10:22 ` [PATCH] TCP : keep copied_seq, rcv_wup and rcv_next together Eric Dumazet
2007-02-22 10:32 ` David Miller
2007-02-22 10:43 ` Eric Dumazet
2007-02-22 11:02 ` David Miller
2007-02-22 11:11 ` [PATCH, take 2] " Eric Dumazet
2007-02-22 11:22 ` David Miller [this message]
2007-02-22 14:50 ` [PATCH] NET : keep sk_backlog near sk_lock Eric Dumazet
2007-03-05 0:05 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070222.032218.59660260.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dada1@cosmosbay.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).